[jira] [Commented] (YARN-10005) Code improvements in MutableCSConfigurationProvider

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629808#comment-17629808 ] 

ASF GitHub Bot commented on YARN-10005:
---------------------------------------

p-szucs opened a new pull request, #5115:
URL: https://github.com/apache/hadoop/pull/5115

   ### Description of PR
   Code improvements in MutableCSConfigurationProvider class:
   - Created ConfUpdateAssembler class to contain logic for ConfUpdate map creation from mutation info
   - Eliminated duplicated code block (9 lines) in init / formatConfigurationInStore methods
   - Changed method "getConfStore" to package-private
   
   ### How was this patch tested?
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> Code improvements in MutableCSConfigurationProvider
> ---------------------------------------------------
>
>                 Key: YARN-10005
>                 URL: https://issues.apache.org/jira/browse/YARN-10005
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Peter Szucs
>            Priority: Minor
>
> * Important: constructKeyValueConfUpdate and all related methods seems a separate responsibility: how to convert incoming SchedConfUpdateInfo to Configuration changes (Configuration object)
> * Duplicated code block (9 lines) in init / formatConfigurationInStore methods
> * Method "getConfStore" could be package-private



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org