You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by da...@apache.org on 2018/11/27 09:56:46 UTC
[04/16] lucene-solr:jira/http2: LUCENE-8216: improve error message
when field weight is invalid
LUCENE-8216: improve error message when field weight is invalid
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/08dd681f
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/08dd681f
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/08dd681f
Branch: refs/heads/jira/http2
Commit: 08dd681f0febcf73af94b47ea742294bf4dd8701
Parents: fd96bc5
Author: Jim Ferenczi <ji...@apache.org>
Authored: Wed Nov 21 10:27:51 2018 +0100
Committer: Jim Ferenczi <ji...@apache.org>
Committed: Wed Nov 21 10:27:51 2018 +0100
----------------------------------------------------------------------
lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java | 2 +-
.../sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/08dd681f/lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java
----------------------------------------------------------------------
diff --git a/lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java b/lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java
index 025d734..b02989d 100644
--- a/lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java
+++ b/lucene/sandbox/src/java/org/apache/lucene/search/BM25FQuery.java
@@ -94,7 +94,7 @@ public final class BM25FQuery extends Query {
*/
public Builder addField(String field, float weight) {
if (weight < 1) {
- throw new IllegalArgumentException("weight must be greater than 1");
+ throw new IllegalArgumentException("weight must be greater or equal to 1");
}
fieldAndWeights.put(field, new FieldAndWeight(field, weight));
return this;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/08dd681f/lucene/sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java
----------------------------------------------------------------------
diff --git a/lucene/sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java b/lucene/sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java
index 8bc8cb1..1dce7da 100644
--- a/lucene/sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java
+++ b/lucene/sandbox/src/test/org/apache/lucene/search/TestBM25FQuery.java
@@ -37,7 +37,7 @@ public class TestBM25FQuery extends LuceneTestCase {
BM25FQuery.Builder builder = new BM25FQuery.Builder();
IllegalArgumentException exc =
expectThrows(IllegalArgumentException.class, () -> builder.addField("foo", 0.5f));
- assertEquals(exc.getMessage(), "weight must be greater than 1");
+ assertEquals(exc.getMessage(), "weight must be greater or equal to 1");
}
public void testRewrite() throws IOException {