You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/01/04 04:44:57 UTC
[PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
dongjoon-hyun opened a new pull request, #272:
URL: https://github.com/apache/spark-connect-swift/pull/272
### What changes were proposed in this pull request?
This PR aims to support `list` data type by syncing with Apache Arrow Swift project.
### Why are the changes needed?
We still cannot use Apache Arrow Swift directly. Until we achieve the goal, we need to sync with the upstream to bring the feature.
- https://github.com/apache/arrow-swift/issues/16
- https://github.com/apache/arrow-swift/pull/39
### Does this PR introduce _any_ user-facing change?
No,
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #272:
URL: https://github.com/apache/spark-connect-swift/pull/272#issuecomment-3707922429
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #272:
URL: https://github.com/apache/spark-connect-swift/pull/272#discussion_r2659505596
##########
Sources/SparkConnect/ArrowType.swift:
##########
@@ -412,6 +426,20 @@ public class ArrowType {
return "z"
case ArrowTypeId.string:
return "u"
+
+ if let structType = self as? ArrowTypeStruct {
Review Comment:
Oops. My bad. I missed `case ArrowTypeId.strct:` here while sycing. Thank you, @viirya .
https://github.com/apache/arrow-swift/pull/39/changes#diff-ba36de6d0bebfc66434379a75262581abdfaf6c1180264ad746da75accdd1e4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #272:
URL: https://github.com/apache/spark-connect-swift/pull/272#issuecomment-3707920484
Thank you, @viirya . `Spark Swift Connect` side test case will be added soon after merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #272: [SPARK-54892] Support `list` data type
URL: https://github.com/apache/spark-connect-swift/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54892] Support `list` data type [spark-connect-swift]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #272:
URL: https://github.com/apache/spark-connect-swift/pull/272#discussion_r2659435323
##########
Sources/SparkConnect/ArrowType.swift:
##########
@@ -412,6 +426,20 @@ public class ArrowType {
return "z"
case ArrowTypeId.string:
return "u"
+
+ if let structType = self as? ArrowTypeStruct {
Review Comment:
I wonder why this `if let structType = self as? ArrowTypeStruct {` is after above `return "u"` for string type? Shouldn't there be `case ArrowTypeId.struct:`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org