You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jpaali (via GitHub)" <gi...@apache.org> on 2023/06/30 10:39:03 UTC
[GitHub] [nuttx] jpaali opened a new pull request, #9657: risc-v/mpfs: cache: Fix cache and scratchpad init
jpaali opened a new pull request, #9657:
URL: https://github.com/apache/nuttx/pull/9657
## Summary
Initialize ICACHE way with correct mask.
Initialize scratchpad with constant g_init_marker as it has been done in HSS nowadays.
## Impact
Fix possible incorrect ICACHE cache way initialization.
## Testing
Tested on a custom MPFS board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jpaali commented on a diff in pull request #9657: risc-v/mpfs: cache: Fix cache and scratchpad init
Posted by "jpaali (via GitHub)" <gi...@apache.org>.
jpaali commented on code in PR #9657:
URL: https://github.com/apache/nuttx/pull/9657#discussion_r1247751127
##########
arch/risc-v/src/mpfs/mpfs_cache.c:
##########
@@ -159,7 +159,7 @@ void mpfs_enable_cache(void)
for (inc = 0; inc < (MPFS_WAY_BYTE_LENGTH /
MPFS_CACHE_BLOCK_BYTE_LENGTH); ++inc)
{
- *p_scratchpad = g_init_marker + inc;
+ *p_scratchpad = g_init_marker /*+ inc*/;
Review Comment:
Sorry, my bad. Deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9657: risc-v/mpfs: cache: Fix cache and scratchpad init
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9657:
URL: https://github.com/apache/nuttx/pull/9657#discussion_r1247732860
##########
arch/risc-v/src/mpfs/mpfs_cache.c:
##########
@@ -159,7 +159,7 @@ void mpfs_enable_cache(void)
for (inc = 0; inc < (MPFS_WAY_BYTE_LENGTH /
MPFS_CACHE_BLOCK_BYTE_LENGTH); ++inc)
{
- *p_scratchpad = g_init_marker + inc;
+ *p_scratchpad = g_init_marker /*+ inc*/;
Review Comment:
What is the purpose of leaving it commented vs deleting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #9657: risc-v/mpfs: cache: Fix cache and scratchpad init
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #9657:
URL: https://github.com/apache/nuttx/pull/9657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org