[GitHub] [airflow] mik-laj commented on a change in pull request #13173: Move logging properties on values.yaml

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#discussion_r546257063



##########
File path: chart/values.yaml
##########
@@ -644,13 +644,13 @@ config:
   core:
     dags_folder: '{{ include "airflow_dags" . }}'
     load_examples: 'False'
-    colored_console_log: 'False'
     executor: '{{ .Values.executor }}'
-    remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
   # Authentication backend used for the experimental API
   api:
     auth_backend: airflow.api.auth.backend.deny_all
   logging:
+    remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'

Review comment:
       Where possible, we try to be compatible with Airflow 1.10 and 2.0 at the same time. I think we need to duplicate these keys. See: https://github.com/apache/airflow/blob/833c53b6a4ebd580c0e5daf75215d38e875d5ddd/chart/values.yaml#L668




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org