[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2776: [connector-v1][doc]Fix inconsistency between document and code logic

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2776:
URL: https://github.com/apache/incubator-seatunnel/pull/2776#discussion_r973708321


##########
docs/en/connector/sink/Jdbc.mdx:
##########
@@ -75,9 +75,9 @@ The transaction isolation level, which applies to current connection. The defaul
 ### customUpdateStmt [string]
 
 Configure when `saveMode` is specified as `update` , which is used to specify the update statement template for key conflicts
-
-Refer to the usage of `INSERT INTO table (...) values (...) ON DUPLICATE KEY UPDATE... ` of `mysql` , use placeholders or fixed values in `values`
-
+if `customUpdateStmt` is empty ,the sql will auto-generate for all columns, else use your sql which refer to the usage of
+`INSERT INTO table (...) values (...) ON DUPLICATE KEY UPDATE... ` of `mysql` , use placeholders or fixed values in `values`
+tips: the tableName of sql should be consistent with the dbName.

Review Comment:
   What's the meaning of this? Do you mean that the table in sql statement should be consistent with `dbTable`? If so, please describe it more clearly



##########
docs/en/connector/sink/Jdbc.mdx:
##########
@@ -56,7 +56,7 @@ user password
 
 ### dbTable [string]
 
-Source data table name
+sink source table name, which will be created if not existed

Review Comment:
   Sink table name, not sink source table name, this is ambiguous. The best description is that `Sink table name, if this table is not existed, it wiil be created`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org