[GitHub] [kafka] jolshan commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

[GitBox <gi...@apache.org>]

jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1052763316


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1338,11 +1337,12 @@ class KafkaApis(val requestChannel: RequestChannel,
   /**
    * Handle an offset fetch request
    */
-  def handleOffsetFetchRequest(request: RequestChannel.Request): Unit = {
+  def handleOffsetFetchRequest(request: RequestChannel.Request): CompletableFuture[Unit] = {
     val version = request.header.apiVersion
     if (version == 0) {
       // reading offsets from ZK
       handleOffsetFetchRequestV0(request)
+      CompletableFuture.completedFuture[Unit](())

Review Comment:
   Is this set up this way (not in the method) because we don't call the group coordinator? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org