You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "Joe Skora (JIRA)" <ji...@apache.org> on 2017/07/13 13:54:00 UTC

[jira] [Created] (NIFI-4183) Fix handshake error logic in SocketFlowFileServerProtocol

Joe Skora created NIFI-4183:
-------------------------------

             Summary: Fix handshake error logic in SocketFlowFileServerProtocol
                 Key: NIFI-4183
                 URL: https://issues.apache.org/jira/browse/NIFI-4183
             Project: Apache NiFi
          Issue Type: Bug
          Components: Core Framework
    Affects Versions: 1.3.0
            Reporter: Joe Skora
            Assignee: Joe Skora
            Priority: Minor


The documentation for SocketFlowFileServerProtocol states that `ServerProtocol.isHandshakeSuccessful()` should return `true` if the handshake succeeded, but `doHandshake()` currently suppresses the `HandshakeException` when it receives an unauthorized, invalid port state, or destination full handshake response.  The original logic appears to be ensuring the final handshake response got sent to the remote system, but it is already accounted for in the current logic.

This change should not affect the existing behavior except to prevent the connection from being considered valid when the handshake throws an unauthorized, invalid port state, or destination full handshake exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)