You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/11/16 11:52:22 UTC
Re: [PR] Backport HIVE-27271: Client connection to HS2 fails when transportMode=http, ssl=true, sslTrustStore specified without trustStorePassword in the JDBC URL [kyuubi]
turboFei commented on code in PR #5712:
URL: https://github.com/apache/kyuubi/pull/5712#discussion_r1395581334
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -559,7 +559,8 @@ public long getRetryInterval() {
// Pick trust store config from the given path
sslTrustStore = KeyStore.getInstance(SSL_TRUST_STORE_TYPE);
try (FileInputStream fis = new FileInputStream(sslTrustStorePath)) {
- sslTrustStore.load(fis, sslTrustStorePassword.toCharArray());
+ sslTrustStore.load(
+ fis, sslTrustStorePassword != null ? sslTrustStorePassword.toCharArray() : null);
Review Comment:
new line is not needed
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -685,7 +686,8 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
SSL_TRUST_STORE + " Not configured for 2 way SSL connection");
}
try (FileInputStream fis = new FileInputStream(trustStorePath)) {
- sslTrustStore.load(fis, trustStorePassword.toCharArray());
+ sslTrustStore.load(
+ fis, trustStorePassword != null ? trustStorePassword.toCharArray() : null);
Review Comment:
new line is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org