You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/10 17:08:56 UTC
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16853
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
[thirpdarty] Improve LLVM build for macOS
This patch adjusts the LLVM build definition to disable simulator
platoforms on OSX that we do not support. This solves the issue
that was worked around via 6597422 in a way that does not prevent
building on aarch64 architectures.
Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
---
M thirdparty/build-definitions.sh
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/16853/1
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
Patch Set 2: Code-Review+2
Thank you for fixing this! I haven't tried to build on macOS HighSierra (10.13), but I guess should works if it works on newer OS versions.
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 23:52:09 +0000
Gerrit-HasComments: No
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh@a348
PS1, Line 348:
> I didn't understand removal of this line.
It's not needed anymore. The previous issue we saw was a result of multiple aarch64 targets, but the above change to remove the various simulators is a permanent fix. We can now revert back to letting the architectures be dictated by the host.
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 18:11:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 18:52:32 +0000
Gerrit-HasComments: No
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16853
to look at the new patch set (#2).
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
[thirpdarty] Improve LLVM build for macOS
This patch adjusts the LLVM build definition to disable simulator
platforms on OSX that we do not support. This solves the issue
that was worked around via 6597422 in a way that does not prevent
building on aarch64 architectures.
Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
---
M thirdparty/build-definitions.sh
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/16853/2
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16853/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16853/1//COMMIT_MSG@10
PS1, Line 10: platoforms
typo
http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh@a348
PS1, Line 348:
I didn't understand removal of this line.
http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh@288
PS1, Line 288: buld
typo
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 18:06:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirpdarty] Improve LLVM build for macOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS
......................................................................
[thirpdarty] Improve LLVM build for macOS
This patch adjusts the LLVM build definition to disable simulator
platforms on OSX that we do not support. This solves the issue
that was worked around via 6597422 in a way that does not prevent
building on aarch64 architectures.
Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Reviewed-on: http://gerrit.cloudera.org:8080/16853
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/build-definitions.sh
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)