[jira] [Commented] (HIVE-20916) Fix typo in JSONCreateDatabaseMessage and add test for alter database

["Bharathkrishna Guruvayoor Murali (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-20916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687108#comment-16687108 ] 

Bharathkrishna Guruvayoor Murali commented on HIVE-20916:
---------------------------------------------------------

+1

> Fix typo in JSONCreateDatabaseMessage and add test for alter database
> ---------------------------------------------------------------------
>
>                 Key: HIVE-20916
>                 URL: https://issues.apache.org/jira/browse/HIVE-20916
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: 4.0.0
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Minor
>         Attachments: HIVE-20916.01.patch
>
>
> {code}
> public JSONCreateDatabaseMessage(String server, String servicePrincipal, Database db,
>       Long timestamp) {
>     this.server = server;
>     this.servicePrincipal = servicePrincipal;
>     this.db = db.getName();
>     this.timestamp = timestamp;
>     try {
>       this.dbJson = MessageBuilder.createDatabaseObjJson(db);
>     } catch (TException ex) {
>       throw new IllegalArgumentException("Could not serialize Function object", ex);
>     }
>     checkValid();
>   }
> {code}
> The exception message should say Database instead of Function. Also, the {{TestDbNotificationListener#createDatabase}} should be modified to make sure that the deserialized database object from the dbJson field matches with the original database object 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)