You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/04/17 05:53:40 UTC

[GitHub] [hbase] Apache9 commented on a diff in pull request #4350: HBASE-26938 Introduce a StoreFileWriterCreationTracker

Apache9 commented on code in PR #4350:
URL: https://github.com/apache/hbase/pull/4350#discussion_r851707084


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -2406,4 +2479,15 @@ void updateMetricsStore(boolean memstoreRead) {
       mixedRowReadsCount.increment();
     }
   }
+
+  /**
+   * Return the storefiles which are currently being written to. Mainly used by
+   * {@link BrokenStoreFileCleaner} to prevent deleting the these files as they are not present in
+   * SFT yet.
+   */
+  Set<Path> getWrittenStoreFiles() {

Review Comment:
   I like filesBeingWritten. Let me change the naming. Thanks both for helping!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org