You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ju...@apache.org on 2010/01/14 23:56:57 UTC

svn commit: r899454 - /pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java

Author: jukka
Date: Thu Jan 14 22:56:56 2010
New Revision: 899454

URL: http://svn.apache.org/viewvc?rev=899454&view=rev
Log:
PDFBOX-603: PDFBox performance issue: Encoding.java getCharacter() method tweak

Patch by Mel Martinez.

Modified:
    pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java

Modified: pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java?rev=899454&r1=899453&r2=899454&view=diff
==============================================================================
--- pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java (original)
+++ pdfbox/trunk/src/main/java/org/apache/pdfbox/encoding/Encoding.java Thu Jan 14 22:56:56 2010
@@ -257,24 +257,17 @@
     public static String getCharacter( COSName name )
     {
         COSName baseName = name;
-        String nameStr = baseName.getName();
-
-        // test if we have a suffix and if so remove it
-        if ( nameStr.indexOf('.') > 0 ) 
-        {
-            nameStr = nameStr.substring( 0, nameStr.indexOf('.') );
-            baseName = COSName.getPDFName( nameStr );
-        }
-
+ 
         String character = (String)NAME_TO_CHARACTER.get( baseName );
         if( character == null )
         {
-            // test for Unicode name
+            String nameStr = baseName.getName();
+           // test for Unicode name
             // (uniXXXX - XXXX must be a multiple of four;
             // each representing a hexadecimal Unicode code point)
             if ( nameStr.startsWith( "uni" ) )
             {
-                StringBuffer uniStr = new StringBuffer();
+                StringBuilder uniStr = new StringBuilder();
 
                 for ( int chPos = 3; chPos + 4 <= nameStr.length(); chPos += 4 ) 
                 {
@@ -304,9 +297,18 @@
             }
             else 
             {
-                character = nameStr;
+                // test if we have a suffix and if so remove it
+                if ( nameStr.indexOf('.') > 0 ) 
+                {
+                    nameStr = nameStr.substring( 0, nameStr.indexOf('.') );
+                    baseName = COSName.getPDFName( nameStr );
+                    getCharacter(baseName);
+                }
+
+               character = nameStr;
             }
         }
         return character;
     } 
+
 }