You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/06/17 01:02:53 UTC
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/605
TAJO-751: JDBC driver should support cancel() method.
This is the rebased patch of navis' work (#459).
While merging the patch into master, I've found some conflict codes and thus removed them.
This patch looks good to me. Here is my +1, and I'll commit if there aren't any objections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-751
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #605
----
commit b7bf01e77b12895607357e9b8a66fd02545b7946
Author: navis.ryu <na...@apache.org>
Date: 2015-03-24T07:07:40Z
TAJO-751 JDBC driver should support cancel() method
commit 659a8d870f09d2b6f2ed15ecb1f17a48a1bb82b7
Author: navis.ryu <na...@apache.org>
Date: 2015-04-08T01:34:09Z
TAJO-751 Added a test and some minor refactorings
commit 8f412ff5c5b12c968ffb0cbed01e414e636442e5
Author: Jihoon Son <ji...@apache.org>
Date: 2015-06-16T22:58:07Z
Merged into master and removed some conflic codes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/605#discussion_r32883566
--- Diff: tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java ---
@@ -319,7 +374,9 @@ public void setCursorName(String name) throws SQLException {
* Not necessary.
*/
@Override
- public void setEscapeProcessing(boolean enable) throws SQLException {}
+ public void setEscapeProcessing(boolean enable) throws SQLException {
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/605#discussion_r32796985
--- Diff: tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java ---
@@ -319,7 +374,9 @@ public void setCursorName(String name) throws SQLException {
* Not necessary.
*/
@Override
- public void setEscapeProcessing(boolean enable) throws SQLException {}
+ public void setEscapeProcessing(boolean enable) throws SQLException {
--- End diff --
Throwing SQLFeatureNotSupportedException may cause JDBC applications to not work. It would be better to print out a warning message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/605#issuecomment-114333315
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/605#issuecomment-113338827
+1
Thanks @jihoonson and @navis
This patch looks good overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-751: JDBC driver should support cancel() m...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/605#issuecomment-112598231
Anyway, I think that it would be great if this patch is included in 0.10.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---