Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #15183:
URL: https://github.com/apache/kafka/pull/15183#discussion_r1457470738


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java:
##########
@@ -92,30 +117,34 @@ public boolean equals(Object o) {
 
         OffsetAndMetadata that = (OffsetAndMetadata) o;
 
-        if (offset != that.offset) return false;
+        if (committedOffset != that.committedOffset) return false;
         if (commitTimestampMs != that.commitTimestampMs) return false;
-        if (!leaderEpoch.equals(that.leaderEpoch)) return false;
-        if (!metadata.equals(that.metadata)) return false;
-        return expireTimestampMs.equals(that.expireTimestampMs);
+        if (recordOffset != that.recordOffset) return false;
+        if (!Objects.equals(leaderEpoch, that.leaderEpoch)) return false;

Review Comment:
   IntelliJ auto-generated this one. We should ask it. :). I suppose that it uses Objects.equals for the reason you mentioned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org