You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/06 06:28:28 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8905: Check target table is empty before scaling job start

codecov-io commented on pull request #8905:
URL: https://github.com/apache/shardingsphere/pull/8905#issuecomment-755110626


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=h1) Report
   > Merging [#8905](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=desc) (a78264b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3e374401d344037d620c30647a911f4a3dfbed3f?el=desc) (3e37440) will **decrease** coverage by `0.07%`.
   > The diff coverage is `48.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8905/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8905      +/-   ##
   ============================================
   - Coverage     69.62%   69.55%   -0.08%     
   - Complexity      625      635      +10     
   ============================================
     Files          1618     1625       +7     
     Lines         25857    25948      +91     
     Branches       4496     4496              
   ============================================
   + Hits          18004    18047      +43     
   - Misses         6648     6687      +39     
   - Partials       1205     1214       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ngsphere/scaling/core/config/JobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSm9iQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...executor/sqlbuilder/AbstractScalingSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3NxbGJ1aWxkZXIvQWJzdHJhY3RTY2FsaW5nU1FMQnVpbGRlci5qYXZh) | `90.00% <0.00%> (-2.31%)` | `0.00 <0.00> (ø)` | |
   | [...he/shardingsphere/scaling/core/job/ScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2NhbGluZ0pvYi5qYXZh) | `90.00% <ø> (-10.00%)` | `0.00 <0.00> (ø)` | |
   | [...ob/preparer/checker/AbstractDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvY2hlY2tlci9BYnN0cmFjdERhdGFTb3VyY2VDaGVja2VyLmphdmE=) | `34.78% <0.00%> (-65.22%)` | `1.00 <0.00> (ø)` | |
   | [...job/preparer/checker/DataSourceCheckerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvY2hlY2tlci9EYXRhU291cmNlQ2hlY2tlckZhY3RvcnkuamF2YQ==) | `66.66% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/scaling/core/utils/TaskConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9UYXNrQ29uZmlndXJhdGlvblV0aWwuamF2YQ==) | `90.24% <0.00%> (+4.87%)` | `54.00 <3.00> (+5.00)` | |
   | [...caling/mysql/component/MySQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jb21wb25lbnQvTXlTUUxEYXRhU291cmNlQ2hlY2tlci5qYXZh) | `86.66% <0.00%> (-6.52%)` | `0.00 <0.00> (-1.00)` | |
   | [...tgresql/component/PostgreSQLDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL3Bvc3RncmVzcWwvY29tcG9uZW50L1Bvc3RncmVTUUxEYXRhU291cmNlQ2hlY2tlci5qYXZh) | `87.50% <0.00%> (-5.84%)` | `1.00 <0.00> (ø)` | |
   | [...ore/service/impl/DistributedScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvRGlzdHJpYnV0ZWRTY2FsaW5nSm9iU2VydmljZS5qYXZh) | `96.15% <90.00%> (-1.53%)` | `1.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VNYW5hZ2VyLmphdmE=) | `87.50% <100.00%> (+1.01%)` | `0.00 <0.00> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/shardingsphere/pull/8905/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=footer). Last update [3e37440...a78264b](https://codecov.io/gh/apache/shardingsphere/pull/8905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org