You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/03/20 14:58:57 UTC
[GitHub] [logging-log4j2] kevinleturc opened a new pull request #351:
LOG4J2-1360 - Provide a Log4j implementation of System.Logger
kevinleturc opened a new pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351
You can find below a POC of JEP 264 implementation with log4j. I may have missed some implementation details, let me know if there's something I can do.
The related ticket: [LOG4J2-1360](https://issues.apache.org/jira/browse/LOG4J2-1360)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on issue #351: LOG4J2-1360 -
Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
rgoers commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-605791148
I am having a difficult time getting the site build to work with this. When I use Java 11 it fails in the JMX GUI module because jconsole isn't provided with Java 11. When I build with Java 8 the javadoc plugin fails in this new module with:
`Exit code: 1 - error: module not found: org.apache.logging.log4j.jpl`
I believe this is because it is using the wrong version of javadoc even though it says it is using the Java 11 version. When I run mvn javadoc:javadoc with Java 11 I don't get this error. I am not prepared to commit this until I can get the site build to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] kevinleturc commented on issue #351: LOG4J2-1360 -
Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
kevinleturc commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-602175494
I added the site section with the right maven plugins to make the build succeed.
In this addition, I faced several issues with tools such as surefire, javadoc, spotbugs or pmd due to toolchain usage. I created a `java11-module` maven profile, activated if jdk is higher than 11, to not loose to many things with the regular build under jdk 8.
- adding module-info.java makes surefire 2.21 failing.
we need surefire 2.13 to make forked VM works with toolchain, but with this version we don't test the modular system -> run the build with surefire 2.13 and add under the java 11 profile a surefire 2.21 configuration with forked VM disabled in order to test modular system
- javadoc doesn't succeed to generate site for classes whose source/target is 9 -> compile everything with a Java 11 LTS
- sportbugs and pmd run on compiled classes and doesn't support toolchain plugin -> I moved their reports under the java 11 profile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on a change in pull request #351:
LOG4J2-1360 - Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
rgoers commented on a change in pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#discussion_r395966722
##########
File path: log4j-jpl/pom.xml
##########
@@ -0,0 +1,255 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>log4j</artifactId>
+ <groupId>org.apache.logging.log4j</groupId>
+ <version>3.0.0-SNAPSHOT</version>
+ <relativePath>../</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <properties>
+ <log4jParentDir>${basedir}/..</log4jParentDir>
+ <module.name>org.apache.logging.log4j.jpl</module.name>
+ </properties>
+
+ <artifactId>log4j-jpl</artifactId>
+ <name>Apache Log4j JDK Platform Logging Adapter</name>
+ <description>The Apache Log4j implementation of java.lang.System.LoggerFinder</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <scope>runtime</scope>
Review comment:
Why is this a runtime dependency? Could this implementation use just the Log4j API to bind to an alternate implementation? If so then log4j-core would just be a test dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers edited a comment on issue #351: LOG4J2-1360
- Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
rgoers edited a comment on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-605791148
I am having a difficult time getting the site build to work with this. When I use Java 11 it fails in the JMX GUI module because jconsole isn't provided with Java 11. When I build with Java 8 the javadoc plugin fails in this new module with:
`Exit code: 1 - error: module not found: org.apache.logging.log4j.jpl`
I believe this is because it is using the wrong version of javadoc even though it says it is using the Java 11 version. When I run mvn javadoc:javadoc with Java 11 I don't get this error. I am not prepared to commit this until I can get the site build to work.
Actually, I think I will just set failonerror to false for this module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on issue #351: LOG4J2-1360 -
Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
rgoers commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-609552898
This was merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] kevinleturc commented on a change in pull request
#351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
kevinleturc commented on a change in pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#discussion_r396075408
##########
File path: log4j-jpl/pom.xml
##########
@@ -0,0 +1,255 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>log4j</artifactId>
+ <groupId>org.apache.logging.log4j</groupId>
+ <version>3.0.0-SNAPSHOT</version>
+ <relativePath>../</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <properties>
+ <log4jParentDir>${basedir}/..</log4jParentDir>
+ <module.name>org.apache.logging.log4j.jpl</module.name>
+ </properties>
+
+ <artifactId>log4j-jpl</artifactId>
+ <name>Apache Log4j JDK Platform Logging Adapter</name>
+ <description>The Apache Log4j implementation of java.lang.System.LoggerFinder</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <scope>runtime</scope>
Review comment:
You were right, we just need log4j-core for testing. Scope was changed to `test`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers closed pull request #351: LOG4J2-1360 -
Provide a Log4j implementation of System.Logger
Posted by GitBox <gi...@apache.org>.
rgoers closed pull request #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services