You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/28 13:29:43 UTC

[GitHub] [tvm] Mousius opened a new pull request, #11162: [CI] Update GoogleTest

Mousius opened a new pull request, #11162:
URL: https://github.com/apache/tvm/pull/11162

   This updates GoogleTest across all our images which also has the side
   effect of using the same version for any host OS.
   
   Rather than updating to a fixed version, I've followed the best practice
   advertised by GoogleTest itself which is the Live-at-Head philosophy:
   https://github.com/google/googletest#live-at-head
   
   Closes #11002
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Mousius merged pull request #11162: [CI] Update GoogleTest

Posted by GitBox <gi...@apache.org>.
Mousius merged PR #11162:
URL: https://github.com/apache/tvm/pull/11162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Mousius commented on pull request #11162: [CI] Update GoogleTest

Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11162:
URL: https://github.com/apache/tvm/pull/11162#issuecomment-1116251144

   Update on the above, I found it was `USE_RELAY_DEBUG` which was causing the C++ tests to seg fault for me, they all passed with this now 😸 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Mousius commented on pull request #11162: [CI] Update GoogleTest

Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11162:
URL: https://github.com/apache/tvm/pull/11162#issuecomment-1112459868

   @areusch I have, and I get the same number of seg faults, which isn't very encouraging for my local environment - need to see what happens in CI here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org