[jira] [Commented] (LUCENE-8296) PendingDeletes shouldn't write to live docs that it shared

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464009#comment-16464009 ] 

Adrien Grand commented on LUCENE-8296:
--------------------------------------

Here is a patch.

> PendingDeletes shouldn't write to live docs that it shared
> ----------------------------------------------------------
>
>                 Key: LUCENE-8296
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8296
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-8296.patch
>
>
> PendingDeletes has a markAsShared mechanism that allow to make sure that the latest livedocs are not going to receive more updates. But it is not always used, and I was able to verify that in some cases we end up with readers whose live docs disagree with the number of deletes. Even though this might not be causing bugs, it feels dangerous to me so I think we should consider always marking live docs as shared in #getLiveDocs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org