You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/10 16:05:54 UTC
[GitHub] [submarine] jiwq opened a new pull request #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
jiwq opened a new pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181
### What is this PR for?
To reduce growth of the indentation mess
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-384
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#issuecomment-585154100
There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to combine to this config (`./submarine/.editorconfig`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#issuecomment-585217039
> There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to combine to this config (`./submarine/.editorconfig`)
@pingsutw Thanks for your focus, I think it's not conflicted. On the contrary, the subproject should better own itself EditorConfig. Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jiwq commented on a change in pull request #181:
SUBMARINE-384. Add EditorConfig metafile to reduce growth of the
indentation mess
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#discussion_r378262508
##########
File path: .editorconfig
##########
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# newline ending every file; no trailing space
+[*]
+charset = utf-8
+insert_final_newline = true
+trim_trailing_whitespace = false
+
+# tab indentation (no size specified)
+[{Makefile,go.mod,go.sum,*.go}]
+indent_style = tab
+
+# 2 space indentation
+[*.{java,json,sh}]
+indent_style = space
+indent_size = 2
+
+# 4 space indentation
+[*.{py,R,xml,js}]
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jiwq edited a comment on issue #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
jiwq edited a comment on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977
> With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?
Hi @liuxunorg, high-frequency IDEs(IDEA/PyCharm/WebStorm/VisualStudio and so on) come bundled with native support for EditorConfig. So the user do not need extra work. More info see [here](https://editorconfig.org/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #181:
SUBMARINE-384. Add EditorConfig metafile to reduce growth of the
indentation mess
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#discussion_r377997801
##########
File path: .editorconfig
##########
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# newline ending every file; no trailing space
Review comment:
If the comment is no trailing space. trim_trailing_whitespace should be true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977
> With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?
High-frequency IDEs(IDEA/PyCharm/WebStorm/VisualStudio and so on) come bundled with native support for EditorConfig. So the user do not need extra work. More info see [here](https://editorconfig.org/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jiwq commented on a change in pull request #181:
SUBMARINE-384. Add EditorConfig metafile to reduce growth of the
indentation mess
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#discussion_r378253807
##########
File path: .editorconfig
##########
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# newline ending every file; no trailing space
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#issuecomment-585223596
Okay. If it's not conflicted, I thought we don't need to change it.
Thanks @jiwq. LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #181:
SUBMARINE-384. Add EditorConfig metafile to reduce growth of the
indentation mess
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#discussion_r377998602
##########
File path: .editorconfig
##########
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# newline ending every file; no trailing space
+[*]
+charset = utf-8
+insert_final_newline = true
+trim_trailing_whitespace = false
+
+# tab indentation (no size specified)
+[{Makefile,go.mod,go.sum,*.go}]
+indent_style = tab
+
+# 2 space indentation
+[*.{java,json,sh}]
+indent_style = space
+indent_size = 2
+
+# 4 space indentation
+[*.{py,R,xml,js}]
Review comment:
Indentation size of pom.xml is 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org