[jira] [Commented] (TS-2907) Unix Sockets

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208426#comment-14208426 ] 

James Peach commented on TS-2907:
---------------------------------

This looks pretty reasonable to me. I had a few comments ...

Remove --enable-unix-socket option. we already assume unix domain socket, let's
just use them.

TS_UNIX_SIZE is not necessary; it's clearer to use sockaddr.sun_path directly.

Do you need to increment the HostDB version number so force traffic_server do
recreate it?

{{bool ats_is_supported_sa(int family)}} should be called
{{ats_is_supported_family()}}.

The comments for {{ats_unix_path_cast()}} seems wrong. AFAICT
{{ats_unix_path_cast()}} doesn't return NULL if applied to the wrong socket type.

I need [~amc] to review the hdrtoken+wks changes for cache compatibility.

In {{HttpTransact::initialize_state_variables_from_request}}, I don't see how
the scheme from {{incoming_request->url_get()}} can be Unix. The Unix scheme is
only for origin requests, so this seems confusing.

In {{remap_parse_config_bti}}, we should raise an error if the {{fromScheme}}
is Unix.

We should mention this feature in the {{remap.config}} documentation.

> Unix Sockets
> ------------
>
>                 Key: TS-2907
>                 URL: https://issues.apache.org/jira/browse/TS-2907
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Luca Rea
>            Assignee: James Peach
>              Labels: review
>             Fix For: 5.2.0
>
>         Attachments: TS-2907.diff, unixsocket-backpost.diff
>
>
> Feature request for support listeners and parents on unix sockets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)