[jira] [Comment Edited] (DOXIASITETOOLS-67) Velocity ToolManager doesn't work for skins and custom templates

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIASITETOOLS-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083568#comment-15083568 ] 

Michael Osipov edited comment on DOXIASITETOOLS-67 at 1/5/16 7:07 PM:
----------------------------------------------------------------------

This isn't quite right. You are probably misunderstanding the use of the tools and how the {{ToolManager}} works. First of all, I wrote some notes [here|https://issues.apache.org/jira/browse/DOXIASITETOOLS-101?focusedCommentId=15076634&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15076634] how we can improve the {{ToolManager}}. It is designed to be created *once* and reused throughout the lifecycle of all rendering events. Therefore, it has several scopes, {{application}} is like {{singleton}} and request is like {{per-lookup}}. We, unfortunately, create the manager always fresh, making all tools effectively request-scoped. Please do not mess up with {{ServletRequest}} which is a layer on top which does not use the {{ToolManager}}. You can check the source of {{VelocityViewServlet}}.


was (Author: michael-o):
This isn't quite right. You are probably misunderstanding the use of the tools and how the {{ToolManager}} works. First of all, I wrote some note [here](https://issues.apache.org/jira/browse/DOXIASITETOOLS-101?focusedCommentId=15076634&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15076634) how we can improve the {{ToolManager}}. It is designed to be created *once* and reused throughout the lifecycle of all rendering event. Therefore, it has several scopes, {{application}} is like {{singleton}} and request is like {{per-lookup}}. We, unfortunately, create the manager always fresh, making all tools request-scoped. Please do not mess up with {{ServletRequest}} which is a layer on to with does not use the {{ToolManager}}. You can check the source of {{VelocityViewServlet}}.

> Velocity ToolManager doesn't work for skins and custom templates
> ----------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-67
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-67
>             Project: Maven Doxia Sitetools
>          Issue Type: Bug
>          Components: Site renderer
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>             Fix For: 1.7
>
>
> DOXIASITETOOLS-66 introduces the Velocity ToolManager, but this only works with the default site rendering settings, because in these cases the classloader changes to pick up the right skin or template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)