You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 02:21:22 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #17499: Decouple getting started standalone back links
tisonkun opened a new pull request, #17499:
URL: https://github.com/apache/pulsar/pull/17499
Fixes #17497
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964667479
##########
site2/docs/tiered-storage-s3.md:
##########
@@ -20,25 +20,8 @@ Follow the steps below to install the S3 offloader.
This example uses Pulsar 2.9.3.
Review Comment:
Let's keep it as is now. I'm unsure whether is the better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964540883
##########
site2/docs/io-quickstart.md:
##########
@@ -26,18 +24,42 @@ the commands used in this tutorial can be used in a multi-node Pulsar cluster wi
Before connecting Pulsar to a database, you need to install Pulsar and the desired built-in connector.
-For more information about **how to install a standalone Pulsar and built-in connectors**, see [here](getting-started-standalone.md/#installing-pulsar).
+Read the [Run a standalone Pulsar cluster locally](getting-started-standalone.md) for downloading the Pulsar distribution.
-## Start Pulsar standalone
+Pulsar releases a separate binary distribution to contain all the built-in connectors. To enable those connectors, you need to download the connectors tarball release:
+
+```bash
+wget pulsar:connector_release_url/{connector}-@pulsar:version@.nar
+```
+
+After you download the NAR file, copy the file to the `connectors` directory in the Pulsar directory. For example, if you download the `pulsar-io-aerospike-@pulsar:version@.nar` connector file, enter the following commands:
+
+```bash
+mkdir connectors
+mv pulsar-io-aerospike-@pulsar:version@.nar connectors
+
+ls connectors
+# pulsar-io-aerospike-@pulsar:version@.nar
+# ...
+```
+
+:::note
+
+* If you are running Pulsar in a bare metal cluster, make sure `connectors` tarball is unzipped in every pulsar directory of the broker (or in every pulsar directory of function-worker if you are running a separate worker cluster for Pulsar Functions).
+* If you are [running Pulsar in Docker](getting-started-docker.md) or deploying Pulsar using a docker image (e.g. [K8S](deploy-kubernetes.md)), you can use the `apachepulsar/pulsar-all` image instead of the `apachepulsar/pulsar` image. `apachepulsar/pulsar-all` image has already bundled all built-in connectors.
Review Comment:
```suggestion
* If you are [running Pulsar in Docker](getting-started-docker.md) or deploying Pulsar using a docker image (e.g. [K8S](deploy-kubernetes.md)), you can use the `apachepulsar/pulsar-all` image instead of the `apachepulsar/pulsar` image. The `apachepulsar/pulsar-all` image has already bundled all built-in connectors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] urfreespace commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
urfreespace commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964578794
##########
site2/docs/reference-configuration.md:
##########
@@ -4,6 +4,6 @@ title: Pulsar configuration
sidebar_label: "Pulsar configuration"
---
-You can manage Pulsar configuration by configuration files in the [`conf`](https://github.com/apache/pulsar/tree/master/conf) directory of a Pulsar [installation](https://pulsar.apache.org/docs/next/getting-started-standalone).
+You can manage Pulsar configuration by configuration files in the `conf` directory of a Pulsar [installation](getting-started-standalone.md).
-For a full list of the configuration of different components, see [Pulsar Reference](https://pulsar.apache.org/reference).
+For a full list of the configuration of different components, see [Pulsar Reference](/reference).
Review Comment:
That's the right way to write it, I think it will work fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
labuladong commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964611349
##########
site2/docs/tiered-storage-aws.md:
##########
@@ -14,50 +14,10 @@ Follow the steps below to install the AWS S3 offloader.
- Pulsar: 2.4.2 or later versions
-### Step
-
This example uses Pulsar 2.5.1.
Review Comment:
```suggestion
```
##########
site2/docs/tiered-storage-azure.md:
##########
@@ -14,50 +14,10 @@ Follow the steps below to install the Azure BlobStore offloader.
- Pulsar: 2.6.2 or later versions
-### Step
-
This example uses Pulsar 2.6.2.
-1. Download the Pulsar tarball using one of the following ways:
-
- * Download from the [Apache mirror](https://archive.apache.org/dist/pulsar/pulsar-2.6.2/apache-pulsar-2.6.2-bin.tar.gz)
-
- * Download from the Pulsar [downloads page](/download)
-
- * Use [wget](https://www.gnu.org/software/wget):
-
- ```shell
- wget https://archive.apache.org/dist/pulsar/pulsar-2.6.2/apache-pulsar-2.6.2-bin.tar.gz
- ```
-
-2. Download and untar the Pulsar offloaders package.
-
- ```bash
- wget https://downloads.apache.org/pulsar/pulsar-2.6.2/apache-pulsar-offloaders-2.6.2-bin.tar.gz
- tar xvfz apache-pulsar-offloaders-2.6.2-bin.tar.gz
- ```
-
-3. Copy the Pulsar offloaders as `offloaders` in the Pulsar directory.
-
- ```
- mv apache-pulsar-offloaders-2.6.2/offloaders apache-pulsar-2.6.2/offloaders
-
- ls offloaders
- ```
-
- **Output**
-
- ```
- tiered-storage-file-system-2.6.2.nar
- tiered-storage-jcloud-2.6.2.nar
- ```
-
- :::note
-
- * If you are running Pulsar in a bare metal cluster, make sure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you are running Pulsar in Docker or deploying Pulsar using a Docker image (such as K8s and DCOS), you can use the `apachepulsar/pulsar-all` image instead of the `apachepulsar/pulsar` image. `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
##########
site2/docs/tiered-storage-filesystem.md:
##########
@@ -20,58 +20,10 @@ This section describes how to install the filesystem offloader.
- Pulsar: 2.4.2 or higher versions
-### Step
-
This example uses Pulsar 2.5.1.
-1. Download the Pulsar tarball using one of the following ways:
-
- * Download the Pulsar tarball from the [Apache mirror](https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz)
-
- * Download the Pulsar tarball from the Pulsar [download page](/download/)
-
- * Use the [wget](https://www.gnu.org/software/wget) command to download the Pulsar tarball.
-
- ```shell
- wget https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz
- ```
-
-2. Download and untar the Pulsar offloaders package.
-
- ```bash
- wget https://downloads.apache.org/pulsar/pulsar-2.5.1/apache-pulsar-offloaders-2.5.1-bin.tar.gz
-
- tar xvfz apache-pulsar-offloaders-2.5.1-bin.tar.gz
- ```
-
- :::note
-
- * If you run Pulsar in a bare-metal cluster, ensure that the `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you run Pulsar in Docker or deploy Pulsar using a Docker image (such as K8S and DCOS), you can use the `apachepulsar/pulsar-all` image. The `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
-
-3. Copy the Pulsar offloaders as `offloaders` in the Pulsar directory.
-
- ```
- mv apache-pulsar-offloaders-2.5.1/offloaders apache-pulsar-2.5.1/offloaders
-
- ls offloaders
- ```
-
- **Output**
-
- ```
- tiered-storage-file-system-2.5.1.nar
- tiered-storage-jcloud-2.5.1.nar
- ```
-
- :::note
-
- * If you run Pulsar in a bare-metal cluster, ensure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you run Pulsar in Docker or deploy Pulsar using a Docker image (such as K8s and DCOS), you can use the `apachepulsar/pulsar-all` image. The `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
##########
site2/docs/tiered-storage-s3.md:
##########
@@ -20,25 +20,8 @@ Follow the steps below to install the S3 offloader.
This example uses Pulsar 2.9.3.
-1. [Download the Pulsar tarball](getting-started-standalone.md#install-pulsar-using-binary-release).
-
-2. Download and untar the Pulsar offloaders package, then copy the Pulsar offloaders as `offloaders` in the Pulsar directory. See [Install tiered storage offloaders](getting-started-standalone.md#install-tiered-storage-offloaders-optional).
-
- **Output**
-
- As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/), [GCS](https://cloud.google.com/storage/), [Azure](https://portal.azure.com/#home), and [Aliyun OSS](https://www.aliyun.com/product/oss) for long-term storage.
-
- ```
- tiered-storage-file-system-2.9.3.nar
- tiered-storage-jcloud-2.9.3.nar
- ```
-
- :::note
-
- * If you run Pulsar in a bare-metal cluster, ensure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you run Pulsar in Docker or deploy Pulsar using a Docker image (such as K8s and DCOS), you can use the `apachepulsar/pulsar-all` image. The `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
##########
site2/docs/tiered-storage-gcs.md:
##########
@@ -14,51 +14,10 @@ Follow the steps below to install the GCS offloader.
- Pulsar: 2.4.2 or later versions
-### Step
-
This example uses Pulsar 2.5.1.
Review Comment:
```suggestion
### Step
```
##########
site2/docs/tiered-storage-aliyun.md:
##########
@@ -14,27 +14,10 @@ Follow the steps below to install the Aliyun OSS offloader.
- Pulsar: 2.8.0 or later versions
-### Step
-
This example uses Pulsar 2.8.0.
Review Comment:
```suggestion
### Step
```
##########
site2/docs/tiered-storage-filesystem.md:
##########
@@ -20,58 +20,10 @@ This section describes how to install the filesystem offloader.
- Pulsar: 2.4.2 or higher versions
-### Step
-
This example uses Pulsar 2.5.1.
Review Comment:
```suggestion
### Step
```
##########
site2/docs/tiered-storage-gcs.md:
##########
@@ -14,51 +14,10 @@ Follow the steps below to install the GCS offloader.
- Pulsar: 2.4.2 or later versions
-### Step
-
This example uses Pulsar 2.5.1.
-1. Download the Pulsar tarball using one of the following ways:
-
- * Download from the [Apache mirror](https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz)
-
- * Download from the Pulsar [download page](/download)
-
- * Use [wget](https://www.gnu.org/software/wget)
-
- ```shell
- wget https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz
- ```
-
-2. Download and untar the Pulsar offloaders package.
-
- ```bash
- wget https://downloads.apache.org/pulsar/pulsar-2.5.1/apache-pulsar-offloaders-2.5.1-bin.tar.gz
-
- tar xvfz apache-pulsar-offloaders-2.5.1-bin.tar.gz
- ```
-
- :::note
-
- * If you are running Pulsar in a bare metal cluster, make sure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you are running Pulsar in Docker or deploying Pulsar using a Docker image (such as K8S and DCOS), you can use the `apachepulsar/pulsar-all` image instead of the `apachepulsar/pulsar` image. `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
-
-3. Copy the Pulsar offloaders as `offloaders` in the Pulsar directory.
-
- ```shell
- mv apache-pulsar-offloaders-2.5.1/offloaders apache-pulsar-2.5.1/offloaders
-
- ls offloaders
- ```
-
- **Output**
-
- ```shell
- tiered-storage-file-system-2.5.1.nar
- tiered-storage-jcloud-2.5.1.nar
- ```
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
##########
site2/docs/tiered-storage-s3.md:
##########
@@ -20,25 +20,8 @@ Follow the steps below to install the S3 offloader.
This example uses Pulsar 2.9.3.
Review Comment:
```suggestion
```
##########
site2/docs/tiered-storage-s3.md:
##########
@@ -20,25 +20,8 @@ Follow the steps below to install the S3 offloader.
This example uses Pulsar 2.9.3.
Review Comment:
I think this sentence can be removed.
##########
site2/docs/tiered-storage-aliyun.md:
##########
@@ -14,27 +14,10 @@ Follow the steps below to install the Aliyun OSS offloader.
- Pulsar: 2.8.0 or later versions
-### Step
-
This example uses Pulsar 2.8.0.
-1. [Download the Pulsar tarball](getting-started-standalone.md#install-pulsar-using-binary-release).
-
-2. Download and untar the Pulsar offloaders package, then copy the Pulsar offloaders as `offloaders` in the Pulsar directory. See [Install tiered storage offloaders](getting-started-standalone.md#install-tiered-storage-offloaders-optional).
-
- **Output**
-
- ```bash
- tiered-storage-file-system-2.8.0.nar
- tiered-storage-jcloud-2.8.0.nar
- ```
-
- :::note
-
- * If you are running Pulsar in a bare-metal cluster, make sure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you are running Pulsar in Docker or deploying Pulsar using a Docker image (such as K8s and DCOS), you can use the `apachepulsar/pulsar-all` image. The `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1240037225
cc @Anonymitaet @momo-jun can you help with merging this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun merged pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
momo-jun merged PR #17499:
URL: https://github.com/apache/pulsar/pull/17499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964669667
##########
site2/docs/tiered-storage-aws.md:
##########
@@ -14,50 +14,10 @@ Follow the steps below to install the AWS S3 offloader.
- Pulsar: 2.4.2 or later versions
-### Step
-
This example uses Pulsar 2.5.1.
-1. Download the Pulsar tarball using one of the following ways:
-
- * Download from the [Apache mirror](https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz)
-
- * Download from the Pulsar [downloads page](/download)
-
- * Use [wget](https://www.gnu.org/software/wget):
-
- ```shell
- wget https://archive.apache.org/dist/pulsar/pulsar-2.5.1/apache-pulsar-2.5.1-bin.tar.gz
- ```
-
-2. Download and untar the Pulsar offloaders package.
-
- ```bash
- wget https://downloads.apache.org/pulsar/pulsar-2.5.1/apache-pulsar-offloaders-2.5.1-bin.tar.gz
- tar xvfz apache-pulsar-offloaders-2.5.1-bin.tar.gz
- ```
-
-3. Copy the Pulsar offloaders as `offloaders` in the Pulsar directory.
-
- ```
- mv apache-pulsar-offloaders-2.5.1/offloaders apache-pulsar-2.5.1/offloaders
-
- ls offloaders
- ```
-
- **Output**
-
- ```
- tiered-storage-file-system-2.5.1.nar
- tiered-storage-jcloud-2.5.1.nar
- ```
-
- :::note
-
- * If you are running Pulsar in a bare metal cluster, make sure that `offloaders` tarball is unzipped in every broker's Pulsar directory.
- * If you are running Pulsar in Docker or deploying Pulsar using a Docker image (such as K8s and DCOS), you can use the `apachepulsar/pulsar-all` image instead of the `apachepulsar/pulsar` image. `apachepulsar/pulsar-all` image has already bundled tiered storage offloaders.
-
- :::
+1. [Download the Pulsar tarball](getting-started-standalone.md).
Review Comment:
```suggestion
1. [Download the Pulsar tarball](getting-started-standalone.md#step-1-download-pulsar-distribution).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239078944
@momo-jun thanks for your review! Comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17499: [fix][docs] decouple getting started standalone back links
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964391125
##########
site2/docs/tiered-storage-aliyun.md:
##########
@@ -18,8 +18,7 @@ Follow the steps below to install the Aliyun OSS offloader.
This example uses Pulsar 2.8.0.
-1. [Download the Pulsar tarball](getting-started-standalone.md#install-pulsar-using-binary-release).
-
+1. [Download the Pulsar tarball](getting-started-standalone.md).
2. Download and untar the Pulsar offloaders package, then copy the Pulsar offloaders as `offloaders` in the Pulsar directory. See [Install tiered storage offloaders](getting-started-standalone.md#install-tiered-storage-offloaders-optional).
Review Comment:
This line and the similar line in `tiered-storage-s3` should be updated. Thus leave this PR as draft for now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239161837
`This example uses Pulsar x.x.x` seems redundant. But if remove them, `### Step` needs to restore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239185649
> This example uses Pulsar x.x.x seems redundant.
@labuladong this patch focuses on fixing backlinks. We do content rewriting as less as possible. You can start a new thread on this topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] DaveDuggins commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
DaveDuggins commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239418427
Reviewed. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964539413
##########
site2/docs/tiered-storage-overview.md:
##########
@@ -4,41 +4,50 @@ title: Overview of tiered storage
sidebar_label: "Overview"
---
-Pulsar's **Tiered Storage** feature allows older backlog data to be moved from BookKeeper to long term and cheaper storage, while still allowing clients to access the backlog as if nothing has changed.
+Pulsar's **Tiered Storage** feature allows older backlog data to be moved from BookKeeper to long term and cheaper storage, while still allowing clients to access the backlog as if nothing has changed.
-* Tiered storage uses [Apache jclouds](https://jclouds.apache.org) to support [Amazon S3](https://aws.amazon.com/s3/), [GCS (Google Cloud Storage)](https://cloud.google.com/storage/), [Azure](https://azure.microsoft.com/en-us/services/storage/blobs/) and [Aliyun OSS](https://www.aliyun.com/product/oss) for long term storage.
+* Tiered storage uses [Apache jclouds](https://jclouds.apache.org) to support [Amazon S3](https://aws.amazon.com/s3/), [GCS (Google Cloud Storage)](https://cloud.google.com/storage/), [Azure](https://azure.microsoft.com/en-us/services/storage/blobs/) and [Aliyun OSS](https://www.aliyun.com/product/oss) for long term storage.
+ * Read how to [Use AWS S3 offloader with Pulsar](tiered-storage-aws.md);
+ * Read how to [Use GCS offloader with Pulsar](tiered-storage-gcs.md);
+ * Read how to [Use Azure BlobStore offloader with Pulsar](tiered-storage-azure.md);
+ * Read how to [Use Aliyun OSS offloader with Pulsar](tiered-storage-aliyun.md);
+ * Read how to [Use S3 offloader with Pulsar](tiered-storage-s3.md).
+* Tiered storage uses [Apache Hadoop](http://hadoop.apache.org/) to support filesystems for long term storage.
Review Comment:
```suggestion
* Tiered storage uses [Apache Hadoop](http://hadoop.apache.org/) to support filesystems for long-term storage.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964541215
##########
site2/docs/io-quickstart.md:
##########
@@ -26,18 +24,42 @@ the commands used in this tutorial can be used in a multi-node Pulsar cluster wi
Before connecting Pulsar to a database, you need to install Pulsar and the desired built-in connector.
-For more information about **how to install a standalone Pulsar and built-in connectors**, see [here](getting-started-standalone.md/#installing-pulsar).
+Read the [Run a standalone Pulsar cluster locally](getting-started-standalone.md) for downloading the Pulsar distribution.
Review Comment:
```suggestion
Read [Run a standalone Pulsar cluster locally](getting-started-standalone.md) for downloading the Pulsar distribution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964540574
##########
site2/docs/io-use.md:
##########
@@ -22,8 +22,7 @@ When using a non-built-in connector, you need to specify the path of an archive
:::
-To set up a built-in connector, follow
-the instructions [here](getting-started-standalone.md#installing-built-in-connectors).
+To set up a built-in connector, follow the instructions [here](io-quickstart.md#install-pulsar-and-built-in-connector).
Review Comment:
```suggestion
To set up a built-in connector, follow the [instructions](io-quickstart.md#install-pulsar-and-built-in-connector).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17499: [fix][docs] decouple getting started standalone back links
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964388271
##########
site2/docs/reference-configuration.md:
##########
@@ -4,6 +4,6 @@ title: Pulsar configuration
sidebar_label: "Pulsar configuration"
---
-You can manage Pulsar configuration by configuration files in the [`conf`](https://github.com/apache/pulsar/tree/master/conf) directory of a Pulsar [installation](https://pulsar.apache.org/docs/next/getting-started-standalone).
+You can manage Pulsar configuration by configuration files in the `conf` directory of a Pulsar [installation](getting-started-standalone.md).
-For a full list of the configuration of different components, see [Pulsar Reference](https://pulsar.apache.org/reference).
+For a full list of the configuration of different components, see [Pulsar Reference](/reference).
Review Comment:
Have you previewed this change? Does the link work?
/ + @SignorMercurio @urfreespace
/ cc @DaveDuggins @momo-jun
##########
site2/docs/io-quickstart.md:
##########
@@ -26,18 +24,42 @@ the commands used in this tutorial can be used in a multi-node Pulsar cluster wi
Before connecting Pulsar to a database, you need to install Pulsar and the desired built-in connector.
-For more information about **how to install a standalone Pulsar and built-in connectors**, see [here](getting-started-standalone.md/#installing-pulsar).
+Read the [Run a standalone Pulsar cluster locally](getting-started-standalone.md) for downloading the Pulsar distribution.
Review Comment:
Can you attach the preview screenshots for lines 27- 50 in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17499: [fix][docs] decouple getting started standalone back links
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964513302
##########
site2/docs/io-quickstart.md:
##########
@@ -26,18 +24,42 @@ the commands used in this tutorial can be used in a multi-node Pulsar cluster wi
Before connecting Pulsar to a database, you need to install Pulsar and the desired built-in connector.
-For more information about **how to install a standalone Pulsar and built-in connectors**, see [here](getting-started-standalone.md/#installing-pulsar).
+Read the [Run a standalone Pulsar cluster locally](getting-started-standalone.md) for downloading the Pulsar distribution.
Review Comment:
<img width="1728" alt="image" src="https://user-images.githubusercontent.com/18818196/188823205-fec8afa5-88c4-43ca-8ac7-6c0ca0e95f71.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17499: [fix][docs] decouple getting started standalone back links
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239045075
This patch is now ready to review. cc @Anonymitaet @momo-jun @labuladong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#issuecomment-1239208101
@labuladong comments addressed. All suggestions about "This example uses Pulsar x.x.x seems redundant." are rejected as mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17499: [fix][docs] getting-started-standalone backlinks
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17499:
URL: https://github.com/apache/pulsar/pull/17499#discussion_r964546526
##########
site2/docs/tiered-storage-overview.md:
##########
@@ -4,41 +4,50 @@ title: Overview of tiered storage
sidebar_label: "Overview"
---
-Pulsar's **Tiered Storage** feature allows older backlog data to be moved from BookKeeper to long term and cheaper storage, while still allowing clients to access the backlog as if nothing has changed.
+Pulsar's **Tiered Storage** feature allows older backlog data to be moved from BookKeeper to long term and cheaper storage, while still allowing clients to access the backlog as if nothing has changed.
Review Comment:
```suggestion
Pulsar's **Tiered Storage** feature allows older backlog data to be moved from BookKeeper to long-term and cheaper storage, while still allowing clients to access the backlog as if nothing has changed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org