You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "i18nsite (via GitHub)" <gi...@apache.org> on 2025/11/30 07:12:23 UTC
[PR] fix xpending end_id [kvrocks]
i18nsite opened a new pull request, #3279:
URL: https://github.com/apache/kvrocks/pull/3279
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream): the wrong end id in XPENDING command [kvrocks]
Posted by "i18nsite (via GitHub)" <gi...@apache.org>.
i18nsite commented on PR #3279:
URL: https://github.com/apache/kvrocks/pull/3279#issuecomment-3594294774
> @PragmaTwice CI failure is not related to this PR, but the test case is required.
我个人建议直接code review这个https://github.com/apache/kvrocks/pull/3277#cn，别拆分成2个提交了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream): the wrong end id in XPENDING command [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #3279:
URL: https://github.com/apache/kvrocks/pull/3279#issuecomment-3594274138
@PragmaTwice CI failure is not related to this PR, but the tese case is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream): the wrong end id in XPENDING command [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #3279:
URL: https://github.com/apache/kvrocks/pull/3279#discussion_r2573616342
##########
src/commands/cmd_stream.cc:
##########
@@ -868,7 +868,7 @@ class CommandXPending : public Commander {
}
if (end_id != "+") {
- auto s = ParseStreamEntryID(start_id, &options_.end_id);
+ auto s = ParseStreamEntryID(end_id, &options_.end_id);
Review Comment:
@i18nsite, could you please add a Go test case to prevent this from happening in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream): the wrong end id in XPENDING command [kvrocks]
Posted by "i18nsite (via GitHub)" <gi...@apache.org>.
i18nsite closed pull request #3279: fix(stream): the wrong end id in XPENDING command
URL: https://github.com/apache/kvrocks/pull/3279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(stream): the wrong end id in XPENDING command [kvrocks]
Posted by "i18nsite (via GitHub)" <gi...@apache.org>.
i18nsite commented on code in PR #3279:
URL: https://github.com/apache/kvrocks/pull/3279#discussion_r2575438121
##########
src/commands/cmd_stream.cc:
##########
@@ -868,7 +868,7 @@ class CommandXPending : public Commander {
}
if (end_id != "+") {
- auto s = ParseStreamEntryID(start_id, &options_.end_id);
+ auto s = ParseStreamEntryID(end_id, &options_.end_id);
Review Comment:
https://github.com/apache/kvrocks/pull/3277/files#diff-09c52b90be671f76754318d6b53aaaa01daf53200c7fc4e6eb921e453366c4fdR66 这个pull request中包含了这个的测试，我这里就不想单独搞了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org