You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by pi...@apache.org on 2012/02/19 16:27:42 UTC
svn commit: r1291014 -
/karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java
Author: pieber
Date: Sun Feb 19 15:27:42 2012
New Revision: 1291014
URL: http://svn.apache.org/viewvc?rev=1291014&view=rev
Log:
Extract "magic strings" into constants
This patch extracts various constant strings from the Karaf
Testframework into string constants making it easier to reuse and read
them.
Signed-off-by: Andreas Pieber <an...@gmail.com>
Modified:
karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java
Modified: karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java
URL: http://svn.apache.org/viewvc/karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java?rev=1291014&r1=1291013&r2=1291014&view=diff
==============================================================================
--- karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java (original)
+++ karaf/trunk/tooling/exam/container/src/main/java/org/apache/karaf/tooling/exam/container/internal/KarafTestContainer.java Sun Feb 19 15:27:42 2012
@@ -91,10 +91,13 @@ import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
public class KarafTestContainer implements TestContainer {
- private static final String KARAF_TEST_CONTAINER = "KarafTestContainer.start";
-
+
private static final Logger LOGGER = LoggerFactory.getLogger(KarafTestContainer.class);
+ private static final String KARAF_TEST_CONTAINER = "KarafTestContainer.start";
+ private static final String EXAM_INVOKER_PROPERTY = "pax.exam.invoker";
+ private static final String EXAM_INJECT_PROPERTY = "pax.exam.inject";
+
private final Runner runner;
private final RMIRegistry registry;
private final ExamSystem system;
@@ -126,8 +129,8 @@ public class KarafTestContainer implemen
systemProperty(RMI_HOST_PROPERTY).value(registry.getHost()),
systemProperty(RMI_PORT_PROPERTY).value("" + registry.getPort()),
systemProperty(RMI_NAME_PROPERTY).value(name),
- systemProperty("pax.exam.invoker").value("junit"),
- systemProperty("pax.exam.inject").value("true")
+ systemProperty(EXAM_INVOKER_PROPERTY).value("junit"),
+ systemProperty(EXAM_INJECT_PROPERTY).value("true")
));
target = new RBCRemoteTarget(name, registry.getPort(), subsystem.getTimeout());