[GitHub] [arrow] mapleFU commented on pull request #35691: GH-34785: [C++][Parquet] Initialize framework for Parquet bloom filter writer

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on PR #35691:
URL: https://github.com/apache/arrow/pull/35691#issuecomment-1554996999

   Some considerations:
   
   1. Bool will not written bloom filter. Standard and Java code allow float/doubel writing bloom filter, so I allow them, but I think they're bad idea.
   2. Parquet-mr support not writting bloom filter if Dictionary is set. I think when dictionary and bloom filter are different things, so, I allow writting bloom filter when dictionary is enabled.
   3. Written values in bloom filter need to write non-null values, so I put them into `ColumnWriterImpl`, hope it would not be ugly.
   
   @pitrou @wjones127 @wgtmac @emkornfield Mind take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org