You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/10 09:43:35 UTC

[GitHub] [flink-jira-bot] zentol opened a new pull request #13: [FLINK-22576] Set status to 'Open' when unassigning

zentol opened a new pull request #13:
URL: https://github.com/apache/flink-jira-bot/pull/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-jira-bot] zentol commented on pull request #13: [FLINK-22576] Set status to 'Open' when unassigning

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #13:
URL: https://github.com/apache/flink-jira-bot/pull/13#issuecomment-836577963


   @tillrohrmann ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-jira-bot] tillrohrmann commented on a change in pull request #13: [FLINK-22576] Set status to 'Open' when unassigning

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13:
URL: https://github.com/apache/flink-jira-bot/pull/13#discussion_r629247148



##########
File path: flink_jira_rule.py
##########
@@ -100,6 +100,7 @@ def close_issue(self, key):
     def unassign(self, key):
         if not self.is_dry_run:
             self.jira_client.assign_issue(key, None)
+            self.jira_client.set_issue_status(key, "Open")

Review comment:
       Does this work even if the JIRA bot is not assigned? I think I always need to assign myself to set a ticket back into "Open".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-jira-bot] zentol commented on a change in pull request #13: [FLINK-22576] Set status to 'Open' when unassigning

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13:
URL: https://github.com/apache/flink-jira-bot/pull/13#discussion_r629270105



##########
File path: flink_jira_rule.py
##########
@@ -100,6 +100,7 @@ def close_issue(self, key):
     def unassign(self, key):
         if not self.is_dry_run:
             self.jira_client.assign_issue(key, None)
+            self.jira_client.set_issue_status(key, "Open")

Review comment:
       I suppose you're right; we first need to assign the bot, then stop progress, and then unassign the ticket.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-jira-bot] zentol merged pull request #13: [FLINK-22576] Set status to 'Open' when unassigning

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13:
URL: https://github.com/apache/flink-jira-bot/pull/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org