[jira] [Commented] (STORM-1603) Storm UT fails on supervisor test in Windows (0.10.x)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179338#comment-15179338 ] 

ASF GitHub Bot commented on STORM-1603:
---------------------------------------

Github user hustfxj commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1183#discussion_r54991044
  
    --- Diff: storm-core/test/clj/backtype/storm/supervisor_test.clj ---
    @@ -261,8 +260,8 @@
                                     (str "-Dstorm.id=" mock-storm-id)
                                     (str "-Dworker.id=" mock-worker-id)
                                     (str "-Dworker.port=" mock-port)
    -                               "-Dstorm.log.dir=/logs"
    -                               "-Dlog4j.configurationFile=/log4j2/worker.xml"
    +                                (str "-Dstorm.log.dir=" file-path-separator "logs")
    +                                (str "-Dlog4j.configurationFile=" file-path-separator "log4j2" file-path-separator "worker.xml")
    --- End diff --
    
    I think you maybe need  fix -Dlog4j.configurationFile as supervisor.clj’s:
    
              log4j-configuration-file (str (if (.startsWith (System/getProperty "os.name") "Windows")
                                              (if (.startsWith storm-log4j2-conf-dir "file:")
                                                storm-log4j2-conf-dir
                                                (str "file:///" storm-log4j2-conf-dir))
                                              storm-log4j2-conf-dir)
                                         Utils/FILE_PATH_SEPARATOR "worker.xml")


> Storm UT fails on supervisor test in Windows (0.10.x)
> -----------------------------------------------------
>
>                 Key: STORM-1603
>                 URL: https://issues.apache.org/jira/browse/STORM-1603
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.10.0
>         Environment: Windows
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> supervisor UTs seem not handle file path delimeter properly so it fails on Windows consistently but no problem on other OS.
> I can easily reproduce this from 0.10.x-branch, but I can't reproduce this from master or 1.x-branch since there're other tests which crash whole tests so that test phase couldn't even reach supervisor-test.
> For 1.x-branch, blobstore crashes test phase on Windows. I'll link relevant issue.
> For master, I'm not sure what issues lay here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)