Re: [PR] [CORE] Add logs in spill for more Spillers [incubator-gluten]

["zhztheplayer (via GitHub)" <gi...@apache.org>]

zhztheplayer commented on code in PR #10117:
URL: https://github.com/apache/incubator-gluten/pull/10117#discussion_r2184209589


##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/NativePlanEvaluator.java:
##########
@@ -86,7 +89,13 @@ public long spill(MemoryTarget self, Spiller.Phase phase, long size) {
                 if (!Spillers.PHASE_SET_SPILL_ONLY.contains(phase)) {
                   return 0L;
                 }
-                return out.spill(size);
+                long spilled = out.spill(size);
+                LOGGER.info(
+                    "NativePlanEvaluator-{}: Spilled {} / {} bytes of data.",
+                    id.get(),
+                    spilled,
+                    size);
+                return spilled;

Review Comment:
   Will the log be too many on `INFO` level?
   
   I remember we once lowered level of a native spill log because it was exploding the log file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org