You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2025/05/01 02:08:45 UTC
[I] P2 Feature request: add a unit test to guard against incorrect key data structure change [iceberg-rust]
dentiny opened a new issue, #1279:
URL: https://github.com/apache/iceberg-rust/issues/1279
### Is your feature request related to a problem or challenge?
The title for the feature request might be confusion, I will explain more here.
The motivation comes from https://github.com/apache/iceberg-rust/pull/1276;
When I was working on the PR to sync upstream iceberg spec change to our rust sdk, I find I have to propagate the schema change to multiple places.
### Describe the solution you'd like
I think there're usually two ways to solve the problem:
- Use codegen to generate schema related changes
+ Example-1: bazel supports [proto_library](https://bazel.build/reference/be/protocol-buffer?authuser=1), which auto-generates protobuf files with one single `bazel build`
+ Example-2: [kuberay](https://github.com/ray-project/kuberay/tree/master/proto) auto-generates grpc client code, http client code and swagger json
- Another way is to add unit tests
+ For example, these two ([1](https://github.com/apache/iceberg-rust/blob/main/crates/iceberg/src/spec/manifest/entry.rs#L472-L495), [2](https://github.com/apache/iceberg-rust/blob/7a5ad1fcaf00d4638857812bab788105f6c60573/crates/iceberg/src/spec/manifest/data_file.rs#L32-L154)) data structures should be consistent with each other, otherwise compilation fails, but new fields won't be persisted into manifest file
### Willingness to contribute
I would be willing to contribute to this feature with guidance from the Iceberg Rust community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] P2 Feature request: add a unit test to guard against incorrect key data structure change [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #1279: P2 Feature request: add a unit test to guard against incorrect key data structure change
URL: https://github.com/apache/iceberg-rust/issues/1279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] P2 Feature request: add a unit test to guard against incorrect key data structure change [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1279:
URL: https://github.com/apache/iceberg-rust/issues/1279#issuecomment-3524467844
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] P2 Feature request: add a unit test to guard against incorrect key data structure change [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1279:
URL: https://github.com/apache/iceberg-rust/issues/1279#issuecomment-3459151200
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org