You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/01 21:45:44 UTC
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.58% -0.22%
==========================================
Files 33 32 -1
Lines 3320 3157 -163
==========================================
- Hits 1919 1818 -101
+ Misses 1324 1270 -54
+ Partials 77 69 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.57% <0.00%> (-2.34%)` | :arrow_down: |
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `67.10% <0.00%> (-0.85%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `80.26% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.66% <0.00%> (ø)` | |
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...56a297a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org