You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/06 10:04:58 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5224: Removed double null check with instance operator
tbw777 opened a new pull request, #5224:
URL: https://github.com/apache/netbeans/pull/5224
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
Also fixed formatting in org.openide.awt.SplittedPanel.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
tbw777 commented on code in PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#discussion_r1063853862
##########
platform/openide.explorer/src/org/openide/explorer/propertysheet/PropertyDialogManager.java:
##########
@@ -120,7 +120,7 @@ public PropertyDialogManager(
if (env != null) {
Object helpID = env.getFeatureDescriptor().getValue(ExPropertyEditor.PROPERTY_HELP_ID);
- if ((helpID != null) && helpID instanceof String && (component != null) && component instanceof JComponent) {
+ if (helpID instanceof String && (component != null) && component instanceof JComponent) {
Review Comment:
Fixed.
Im entirely agree about task splitting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#issuecomment-1373424861
https://github.com/apache/netbeans/pull/5205 reopened with code format fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#issuecomment-1377156971
@sdedic I dont see errors. Who can review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#issuecomment-1380809986
Rerunning all tests finally fixed the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#discussion_r1063827922
##########
platform/openide.explorer/src/org/openide/explorer/propertysheet/PropertyDialogManager.java:
##########
@@ -120,7 +120,7 @@ public PropertyDialogManager(
if (env != null) {
Object helpID = env.getFeatureDescriptor().getValue(ExPropertyEditor.PROPERTY_HELP_ID);
- if ((helpID != null) && helpID instanceof String && (component != null) && component instanceof JComponent) {
+ if (helpID instanceof String && (component != null) && component instanceof JComponent) {
Review Comment:
Yet another != null && instanceof :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5224:
URL: https://github.com/apache/netbeans/pull/5224#issuecomment-1379498828
The `java.mx.project` suite is failing. I ran it locally on JDK 8 and it works - so lets try the next retries (this is number 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #5224: Removed double null check with instance operator
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #5224:
URL: https://github.com/apache/netbeans/pull/5224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists