You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2014/04/22 22:52:15 UTC
[jira] [Updated] (ACCUMULO-2511) Value allows equals(byte[])
[ https://issues.apache.org/jira/browse/ACCUMULO-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Drob updated ACCUMULO-2511:
--------------------------------
Labels: findbugs incompatible (was: incompatible)
> Value allows equals(byte[])
> ---------------------------
>
> Key: ACCUMULO-2511
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2511
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Sean Busbey
> Labels: findbugs, incompatible
>
> Right now the equals(Object) method for Value is
> {noformat}
> @Override
> public boolean equals(Object right_obj) {
> if (right_obj instanceof byte[]) {
> return compareTo((byte[]) right_obj) == 0;
> }
> if (right_obj instanceof Value) {
> return compareTo(right_obj) == 0;
> }
> return false;
> }
> {noformat}
> It's in a section that says it was copied from BytesWritable.
> If we're not using this optimization anywhere, I'd rather remove it since it is non-intuitive.
> If we are using it, I'd prefer we move it into something other than the general equals
--
This message was sent by Atlassian JIRA
(v6.2#6252)