[GitHub] [airflow] uranusjr opened a new pull request, #26702: When rendering template, unmap task in context

[GitBox <gi...@apache.org>]

uranusjr opened a new pull request, #26702:
URL: https://github.com/apache/airflow/pull/26702

   Currently, when a mapped task is being rendered (and unmapped during the process), the template context continues to reference the mapped task because the context is created before unmapping. This is however not useful, and creates obstacles for use cases needing to reference a task-mapping value (something passed to the expand function).
   
   This patch adds logic to replace `context["task"]` and `context["ti"].task` in-place when a mapped task is being unmapped, so they always reference an unmapped task during template rendering. This makes writing a Jinja template for a mapped task more consistent to that for a non-mapped one.
   
   To accommodate this change in reference, some peripheral code is modified so various task variables point to the right things at the right moment. A few tests are also modified to ensure this in-place replacement is done at the right moment.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #26702: When rendering template, unmap task in context

[GitBox <gi...@apache.org>]

uranusjr commented on PR #26702:
URL: https://github.com/apache/airflow/pull/26702#issuecomment-1259321964

   Something’s wrong with yarnpkg… hopefully temporary?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr merged pull request #26702: When rendering template, unmap task in context

[GitBox <gi...@apache.org>]

uranusjr merged PR #26702:
URL: https://github.com/apache/airflow/pull/26702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org