[GitHub] [hudi] CTTY commented on a diff in pull request #6752: [HUDI-4010] Improve docs on DynamoDB-based lock provider

[GitBox <gi...@apache.org>]

CTTY commented on code in PR #6752:
URL: https://github.com/apache/hudi/pull/6752#discussion_r978236529


##########
website/docs/concurrency_control.md:
##########
@@ -71,16 +71,26 @@ hoodie.write.lock.hivemetastore.table
 
 **`Amazon DynamoDB`** based lock provider
 
-Amazon DynamoDB based lock provides a simple way to support multi writing across different clusters
+Amazon DynamoDB based lock provides a simple way to support multi writing across different clusters.  You can refer to the
+[DynamoDB based Locks Configurations](https://hudi.apache.org/docs/configurations#DynamoDB-based-Locks-Configurations)
+section for the details of each related configuration knob.
 
 ```
 hoodie.write.lock.provider=org.apache.hudi.aws.transaction.lock.DynamoDBBasedLockProvider
-hoodie.write.lock.dynamodb.table
-hoodie.write.lock.dynamodb.partition_key
-hoodie.write.lock.dynamodb.region
-hoodie.write.lock.dynamodb.endpoint_url
-hoodie.write.lock.dynamodb.billing_mode
-```
+hoodie.write.lock.dynamodb.table (required)
+hoodie.write.lock.dynamodb.partition_key (optional)
+hoodie.write.lock.dynamodb.region (optional)
+hoodie.write.lock.dynamodb.endpoint_url (optional)
+hoodie.write.lock.dynamodb.billing_mode (optional)

Review Comment:
   Why no mark configs versioned_docs with `required/optional` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org