You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/16 02:02:36 UTC

[GitHub] [beam] ihji commented on a change in pull request #14557: Add --sdk_container_image flag for specifying SDK harness container image

ihji commented on a change in pull request #14557:
URL: https://github.com/apache/beam/pull/14557#discussion_r614512132



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -859,13 +859,14 @@ def _add_argparse_args(cls, parser):
             'subnetwork name. For more information, see '
             'https://cloud.google.com/compute/docs/vpc/'))
     parser.add_argument(
+        '--sdk_container_image',

Review comment:
       Any reason to use `sdk_container_image` not `sdk_harness_container_image`? The term `sdk_harness_container` is already used in the option `--sdk_harness_container_image_overrides` below. I think it would be better to use the same one for the both options (either `sdk_harness_container_image` here or `sdk_container_image_overrides` there).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org