You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/12 12:53:05 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1695: HDDS-4207. Include version information in docs
adoroszlai opened a new pull request #1695:
URL: https://github.com/apache/ozone/pull/1695
## What changes were proposed in this pull request?
Display version from POM in documentation footer.
If building in a git working copy, also display last commit date and hash, with link to GitHub.
https://issues.apache.org/jira/browse/HDDS-4207
## How was this patch tested?
Built docs locally (`mvn clean package` in `hadoop-hdds/docs`), both in git repo and in `hadoop-ozone-1.0.0-src`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1695: HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-745062499
Thanks @vivekratnavel for taking a look.
> How do I see the version after "mvn clean package"?
* `open hadoop-hdds/docs/target/classes/docs/index.html` if only built `hadoop-hdds-docs`
* `open hadoop-ozone/dist/target/ozone-1.1.0-SNAPSHOT/docs/index.html` after full build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel commented on pull request #1695: HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-745645692
Thanks @adoroszlai! I also noticed one more thing. The footer does not stick at the bottom of the screen.
For pages with content that do not occupy the full screen, we see the footer with version immediately in the middle of the screen as shown in the screen-shot attached. We should either make this footer stick to the bottom of the screen always or we should this version information in a different space. One alternate space I can think of is the bottom of the left menu bar.
<img width="1680" alt="Screen Shot 2020-12-15 at 3 12 30 PM" src="https://user-images.githubusercontent.com/1051198/102283820-f6910a00-3ee7-11eb-8c1c-50b3b70cd29b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel commented on pull request #1695: [Docs] HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-747242398
I referred to this post for sticky footer - https://css-tricks.com/couple-takes-sticky-footer/ and pushed a commit.
Please check and let me know how it looks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1695: [Docs] HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-747263212
> I referred to this post for sticky footer - https://css-tricks.com/couple-takes-sticky-footer/ and pushed a commit.
>
> Please check and let me know how it looks.
Thank you very much @vivekratnavel. It looks great on both long and short pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #1695: [Docs] HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1695:
URL: https://github.com/apache/ozone/pull/1695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1695: HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-746324369
> For pages with content that do not occupy the full screen, we see the footer with version immediately in the middle of the screen as shown in the screen-shot attached.
Thanks @vivekratnavel. I tried, but don't know enough CSS to achieve this. Can you give me some pointer or hint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1695: [Docs] HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-747511404
Thanks @vivekratnavel for the review and help with the sticky footer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel edited a comment on pull request #1695: [Docs] HDDS-4207. Include version information in docs
Posted by GitBox <gi...@apache.org>.
vivekratnavel edited a comment on pull request #1695:
URL: https://github.com/apache/ozone/pull/1695#issuecomment-745645692
Thanks @adoroszlai! I also noticed one more thing. The footer does not stick at the bottom of the screen.
For pages with content that do not occupy the full screen, we see the footer with version immediately in the middle of the screen as shown in the screen-shot attached. We should either make this footer stick to the bottom of the screen always or we should show this version information in a different space. One alternate space I can think of is the bottom of the left menu bar.
<img width="1680" alt="Screen Shot 2020-12-15 at 3 12 30 PM" src="https://user-images.githubusercontent.com/1051198/102283820-f6910a00-3ee7-11eb-8c1c-50b3b70cd29b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org