You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2024/01/19 07:40:25 UTC

[PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

mrproliu opened a new pull request, #157:
URL: https://github.com/apache/skywalking-showcase/pull/157

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #157:
URL: https://github.com/apache/skywalking-showcase/pull/157#discussion_r1459191440


##########
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##########
@@ -57,13 +60,21 @@ spec:
             - name: ROVER_BACKEND_ADDR
               value: {{ template "skywalking.collector.address" . }}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
               value: skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_HOST_MAPPING
               value: /host
+            - name: ROVER_CORE_CLUSTER_NAME
+              value: skywalking-showcase
+            - name: ROVER_ACCESS_LOG_ACTIVE
+              value: "true"
+            - name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+              value: gmp-system,kube-system,skywalking-showcase

Review Comment:
   The namespace `skywalking-showcase` should not be hardcoded



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #157:
URL: https://github.com/apache/skywalking-showcase/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #157:
URL: https://github.com/apache/skywalking-showcase/pull/157#discussion_r1459205515


##########
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##########
@@ -57,13 +60,21 @@ spec:
             - name: ROVER_BACKEND_ADDR
               value: {{ template "skywalking.collector.address" . }}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
               value: skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_HOST_MAPPING
               value: /host
+            - name: ROVER_CORE_CLUSTER_NAME
+              value: skywalking-showcase
+            - name: ROVER_ACCESS_LOG_ACTIVE
+              value: "true"
+            - name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+              value: gmp-system,kube-system,skywalking-showcase

Review Comment:
   Will be mutable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #157:
URL: https://github.com/apache/skywalking-showcase/pull/157#discussion_r1460713808


##########
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##########
@@ -57,13 +60,21 @@ spec:
             - name: ROVER_BACKEND_ADDR
               value: {{ template "skywalking.collector.address" . }}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
               value: skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_HOST_MAPPING
               value: /host
+            - name: ROVER_CORE_CLUSTER_NAME
+              value: skywalking-showcase
+            - name: ROVER_ACCESS_LOG_ACTIVE
+              value: "true"
+            - name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+              value: gmp-system,kube-system,skywalking-showcase

Review Comment:
   @mrproliu Could you follow this env variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #157:
URL: https://github.com/apache/skywalking-showcase/pull/157#discussion_r1460701412


##########
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##########
@@ -57,13 +60,21 @@ spec:
             - name: ROVER_BACKEND_ADDR
               value: {{ template "skywalking.collector.address" . }}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
-              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+              value: mesh-svr::{{"{{"}}.Pod.LabelValue "service.istio.io/canonical-name,app.kubernetes.io/name,app" ""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
               value: skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
             - name: ROVER_HOST_MAPPING
               value: /host
+            - name: ROVER_CORE_CLUSTER_NAME
+              value: skywalking-showcase
+            - name: ROVER_ACCESS_LOG_ACTIVE
+              value: "true"
+            - name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+              value: gmp-system,kube-system,skywalking-showcase

Review Comment:
   It's configurable when installing showcase like `make deploy.kubernetes NAMESPACE=demo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org