You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2019/02/25 16:21:10 UTC

[GitHub] osma commented on issue #536: Add support SurroundQueryParser to jena-text

osma commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-467075475
 
 
   I think it's a pity this PR merges the two methods into one, making the code a bit messier and more difficult to understand. Is that because SurroundQueryParser doesn't implement the normal QueryParser interface?
   
   Other than that, I don't have any objections to this PR, it even comes with unit tests. Docs have to be updated too after the merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services