You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/26 03:53:41 UTC
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9764: [style] (fe) wrap and whitespace rules
morningman commented on code in PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#discussion_r882264236
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
Review Comment:
remove
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
+
+ public boolean isUnNullSafeEquivalence() {
+ return this == EQ;
+ }
- public boolean isUnNullSafeEquivalence() { return this == EQ; };
+ ;
Review Comment:
remove
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org