You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "spenczar (via GitHub)" <gi...@apache.org> on 2023/05/29 22:32:57 UTC
[GitHub] [arrow] spenczar opened a new pull request, #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
spenczar opened a new pull request, #35813:
URL: https://github.com/apache/arrow/pull/35813
Discussed in #35624, particularly at https://github.com/apache/arrow/issues/35624#issuecomment-1561345012.
Doesn't close that issue, but it came up in discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] spenczar commented on pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
Posted by "spenczar (via GitHub)" <gi...@apache.org>.
spenczar commented on PR #35813:
URL: https://github.com/apache/arrow/pull/35813#issuecomment-1568787509
Oops! Thanks for directly fixing it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35813:
URL: https://github.com/apache/arrow/pull/35813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #35813:
URL: https://github.com/apache/arrow/pull/35813#discussion_r1210576875
##########
python/pyarrow/compute.py:
##########
@@ -483,10 +483,16 @@ def take(data, indices, *, boundscheck=True, memory_pool=None):
def fill_null(values, fill_value):
- """
- Replace each null element in values with fill_value. The fill_value must be
- the same type as values or able to be implicitly casted to the array's
- type.
+ """Replace each null element in values with a corresponding
+ element from fill_value.
+
+ If fill_value is scalar-like, then every null element in values
+ will be replaced with fill_value. If fill_value is array-like,
+ then the i-th element in values will be replaced witth the i-th
Review Comment:
```suggestion
then the i-th element in values will be replaced with the i-th
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35813:
URL: https://github.com/apache/arrow/pull/35813#issuecomment-1570137731
Benchmark runs are scheduled for baseline = 26952930e0a1525814715190a5ef399ec0c9e383 and contender = e628ca50078c749ea7a10b53defe12cbec7d581f. e628ca50078c749ea7a10b53defe12cbec7d581f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b26b742163d04594add15dd80d8711ba...5b271a3e36fd4875a2996e43ee0699da/)
[Failed :arrow_down:0.73% :arrow_up:0.12%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a8c0ce5564ed4ac3a176f27e1d9cf81a...24aaee3897904d3db0abad9cb8290eb6/)
[Finished :arrow_down:2.29% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ce052d62674e4d198262f2fd9490e5b9...a3612ca944a94d21bba9fa2ade0663cc/)
[Finished :arrow_down:1.08% :arrow_up:0.12%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/99975a630ce14aa79f9470fd63b9fc1d...452aaeebd032485c8b162b6d4d8d072b/)
Buildkite builds:
[Finished] [`e628ca50` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2952)
[Failed] [`e628ca50` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2988)
[Finished] [`e628ca50` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2953)
[Finished] [`e628ca50` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2978)
[Finished] [`26952930` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2951)
[Failed] [`26952930` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2987)
[Finished] [`26952930` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2952)
[Finished] [`26952930` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2977)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35813: MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35813:
URL: https://github.com/apache/arrow/pull/35813#issuecomment-1568835575
CI failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org