You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/10/11 14:08:58 UTC
[jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Note that the build will fail until the SNAPSHOTS generated for https://github.com/jclouds/jclouds/pull/567 are published.
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs-google exclusion-cidr
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/57
-- Commit Summary --
* Implemented the supports exclusion CIDR new method
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java (5)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/57.patch
https://github.com/jclouds/jclouds-labs-google/pull/57.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by Andrew Phillips <no...@github.com>.
+1 - good to go for me. We can fix the indenting (4-space instead of 3-space) during the merge.
Thanks, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58803595
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by Ignasi Barrera <no...@github.com>.
Closed #57.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#event-177263629
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by Ignasi Barrera <no...@github.com>.
Reopened #57.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#event-177263649
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1452](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1452/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58747557
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by Andrew Phillips <no...@github.com>.
> @@ -321,6 +321,11 @@ public boolean supportsPortRangesForGroups() {
> return true;
> }
>
> + @Override
> + public boolean supportsExclusionCidrBlocks() {
> + return false;
Thanks for fixing the indent, @nacx ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57/files#r18750890
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #155](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/155/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58749555
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1454](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1454/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58749651
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #154](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/154/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58747551
Re: [jclouds-labs-google] Implemented the supports exclusion CIDR new
method (#57)
Posted by Ignasi Barrera <no...@github.com>.
Let's see if the snapshots are in place now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/57#issuecomment-58749486