You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/08 07:25:44 UTC
[GitHub] [echarts] Ovilia opened a new pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
Ovilia opened a new pull request #14243:
URL: https://github.com/apache/echarts/pull/14243
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
`visualMap[piecewise].itemSymbol` took no effect.
### Fixed issues
- #5719: itemSymbol in the visualMap (piecewise) can't be set
## Details
### Before: What was the problem?
`visualMap[piecewise].itemSymbol` took no effect.
### After: How is it fixed in this PR?
`visualMap[piecewise].itemSymbol` should be used as default symbol type when `symbol` is not defined in visualMap pieces.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
- `test/visualMap-scatter-colorAndSymbol.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14243:
URL: https://github.com/apache/echarts/pull/14243#issuecomment-814590600
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14243:
URL: https://github.com/apache/echarts/pull/14243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14243:
URL: https://github.com/apache/echarts/pull/14243#discussion_r603756637
##########
File path: src/component/visualMap/VisualMapModel.ts
##########
@@ -511,7 +516,7 @@ class VisualMapModel<Opts extends VisualMapOption = VisualMapOption> extends Com
// Filter square and none.
visuals.symbol = mapVisual(visuals.symbol, function (symbol) {
- return (symbol === 'none' || symbol === 'square') ? 'roundRect' : symbol;
+ return (symbol === 'none' || symbol === 'square') ? defaultSymbol : symbol;
Review comment:
@100pah Do you still remember why the `'square'` symbol needs to be filtered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14243:
URL: https://github.com/apache/echarts/pull/14243#issuecomment-774933353
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org