You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/06/24 11:37:09 UTC

Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89324
-----------------------------------------------------------



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 41)
<https://reviews.apache.org/r/35821/#comment141909>

    Constructor does not enforces to take 3 weights for partitions. Is this comment valid ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 45)
<https://reviews.apache.org/r/35821/#comment141910>

    final keyword can be used in arguments.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 60)
<https://reviews.apache.org/r/35821/#comment141911>

    final in arguments.


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89150
-----------------------------------------------------------



lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java (line 61)
<https://reviews.apache.org/r/35821/#comment141753>

    Could we remove these fields estimatedResourceUsage and estimatedExecTimeMillis ?
    
    They are dummy fields which are not populated with actual useful values today. As a disadvantage of keeping them, they are making compareTO function complex.



lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java (line 64)
<https://reviews.apache.org/r/35821/#comment141752>

    Comment is not in sync with field name.


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 4, 2015, 12:31 a.m., Himanshu Gahlaut wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 346
> > <https://reviews.apache.org/r/35821/diff/3/?file=998853#file998853line346>
> >
> >     Please return an ImmutableMap here.

Removed.


> On July 4, 2015, 12:31 a.m., Himanshu Gahlaut wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java, line 170
> > <https://reviews.apache.org/r/35821/diff/3/?file=998850#file998850line170>
> >
> >     Please accept an ImmutableMap in this method and final.

Removed


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90366
-----------------------------------------------------------


On July 3, 2015, 5:38 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 5:38 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 3, 2015, 7:01 p.m., Himanshu Gahlaut wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java, line 63
> > <https://reviews.apache.org/r/35821/diff/3/?file=998856#file998856line63>
> >
> >     This check appears to be out of context or redundant.
> >     Code block in if is not dereferencing the result returned from queryContext.getDriverContext().getDriverRewriterPlan(driver).

Seems like this check shall be inside getAllPartitions private method of this class, which is dereferencing queryContext.getDriverContext().getDriverRewriterPlan(driver). getAllPartitions method can return an empty map if DriverRewriterPlan is null. This will move the check near to the code which cares about it.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90366
-----------------------------------------------------------


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90366
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java (line 168)
<https://reviews.apache.org/r/35821/#comment143394>

    Please accept an ImmutableMap in this method and final.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 340)
<https://reviews.apache.org/r/35821/#comment143393>

    Please return an ImmutableMap here.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 368)
<https://reviews.apache.org/r/35821/#comment143395>

    Code is not doing explain any more here. It can be removed from comment.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java (line 37)
<https://reviews.apache.org/r/35821/#comment143396>

    This can be changed to Guava ImmutableMap and also the same can be accepted in constructor.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java (line 63)
<https://reviews.apache.org/r/35821/#comment143397>

    This check appears to be out of context or redundant.
    Code block in if is not dereferencing the result returned from queryContext.getDriverContext().getDriverRewriterPlan(driver).



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java (line 89)
<https://reviews.apache.org/r/35821/#comment143398>

    Could there be an update period without weight ? If not, then this shall be ensured in constructor of this class to construct the object in valid state and relieve behaviours from caring about the same. If there could be an update period without weight, what is the use case for the same ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90352
-----------------------------------------------------------



lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java (line 31)
<https://reviews.apache.org/r/35821/#comment143367>

    This is good finding to use generics here and avoid typecasting in implementation of add method. 
    Would this thought be more reusable if code has a reusable Addable interface in lens-api module ?
    
    ```
    in lens-api module:
    
    public interface Addable<T> {
      T add(final T t);
    }
    
    in lens-server-api module:
    
    public interface QueryCost extends Comparable<T>, Addable<T> {
    
    }
    
    in lens-server module:
    
    public class FactPartitionBasedQueryCost implements QueryCost {
    
    }
    ```
    
    Can QueryCost interface and FactPartitionBasedQueryCost impl move to lens-server-api and lens-server module respectively ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 3, 2015, 6:22 p.m., Himanshu Gahlaut wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java, line 49
> > <https://reviews.apache.org/r/35821/diff/3/?file=998854#file998854line49>
> >
> >     If this is an used variable now, can this be removed ?

*unused


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90359
-----------------------------------------------------------


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 3, 2015, 11:52 p.m., Himanshu Gahlaut wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java, line 178
> > <https://reviews.apache.org/r/35821/diff/3/?file=998850#file998850line178>
> >
> >     Could we rename weight to sumOfStorageTableWeights
> >     and method to getSumOfStorageTableWeights() ?
> >     
> >     Can we return 0 and let the client decide whether it wants to use 0 or not ?  Sum of all storage table weights shall be 0 when there are no storage tables. In scope of this class, its hard to understand how sum of storage table weights is 1 when there are no storage tables.

sum is also 1 when the map passed has no values. so sum of storage table weights will be different with different values of the map argument. I feel removing this abstraction would be a more reasonable thing to do.


> On July 3, 2015, 11:52 p.m., Himanshu Gahlaut wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java, line 46
> > <https://reviews.apache.org/r/35821/diff/3/?file=998856#file998856line46>
> >
> >     Please use @NonNull on arguments here. Can Map be empty, if not can we put a checkArgument for the same ?

Removed the argument. FPBQCC is a separate entity now. It's only invoked in cost calculation with args query context and the driver. Driver's conf is picked for getting this map.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90359
-----------------------------------------------------------


On July 3, 2015, 5:38 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 5:38 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90359
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java (line 176)
<https://reviews.apache.org/r/35821/#comment143380>

    Could we rename weight to sumOfStorageTableWeights
    and method to getSumOfStorageTableWeights() ?
    
    Can we return 0 and let the client decide whether it wants to use 0 or not ?  Sum of all storage table weights shall be 0 when there are no storage tables. In scope of this class, its hard to understand how sum of storage table weights is 1 when there are no storage tables.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java (line 46)
<https://reviews.apache.org/r/35821/#comment143382>

    If this is an used variable now, can this be removed ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java (line 46)
<https://reviews.apache.org/r/35821/#comment143383>

    Please use @NonNull on arguments here. Can Map be empty, if not can we put a checkArgument for the same ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90365
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java (line 36)
<https://reviews.apache.org/r/35821/#comment143392>

    Please add @NonNull



lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java (line 41)
<https://reviews.apache.org/r/35821/#comment143391>

    Please add final in arguments accepted in this class constructor and behaviours.



lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java (line 29)
<https://reviews.apache.org/r/35821/#comment143390>

    could we remove normalized keyword or define normalization scale ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90355
-----------------------------------------------------------



lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java (line 25)
<https://reviews.apache.org/r/35821/#comment143376>

    "a light cost flight" 
    
    vs
    
    "a low cost flight"
    
    Light Cost: https://www.google.co.in/?gfe_rd=cr&ei=OsmWVfONAoLK8AfJn4GADA#q=light+cost
    
    Low Cost: https://www.google.co.in/?gfe_rd=cr&ei=OsmWVfONAoLK8AfJn4GADA#q=low+cost
    
    http://www.lowcostairlines.com/
    
    Convention of low cost and high cost is sounding better to me than light cost and heavy cost. What do you think ? Or is there a third way of representing the same as well better than both of these ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90466
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java (line 43)
<https://reviews.apache.org/r/35821/#comment143531>

    Can you add documentation for what this normalization factor is? And how did we come up with value?



lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 223)
<https://reviews.apache.org/r/35821/#comment143532>

    Are we always returning 0,0 in query cost? why?


- Amareshwari Sriramadasu


On July 6, 2015, 10:53 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 10:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90870
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java (line 48)
<https://reviews.apache.org/r/35821/#comment144027>

    Could we rename context to query or queryContext or queryCtx;



lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java (line 67)
<https://reviews.apache.org/r/35821/#comment144028>

    Could we reduce the length of setUp method by writing a private method as below ?
    
    ```
    private getMockFactPartWithStubbing(final UpdatePeriod mockUpdatePeriod, final Map mockWeightMap, final int mockTableWeight) {
     
     FactPartition mockFp = mock(FactPartition.class);
     when(fp.getPeriod()).thenReturn(updatePeriod);
     when(fp.getAllTableWeights(mockWeightMap)).thenReturn(mockTableWeight);
     return mockFp; 
    }



lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java (line 83)
<https://reviews.apache.org/r/35821/#comment144029>

    Please remove System.out.


- Himanshu Gahlaut


On July 7, 2015, 10:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:37 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90868
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java (line 168)
<https://reviews.apache.org/r/35821/#comment144024>

    Could we accept a final ImmutableMap here ?


- Himanshu Gahlaut


On July 7, 2015, 10:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:37 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90872
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java (line 72)
<https://reviews.apache.org/r/35821/#comment144030>

    Since the type is Double, do we need to assign it using float initialization ? How about using just 0.7 ?



lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java (line 44)
<https://reviews.apache.org/r/35821/#comment144031>

    Test case can be written as below without the need of making partitionCost package private.
    
    QueryCost expectedResult = new QueryCost(0.50);
    
    assertEquals(cost1.add(cost2), expectedResult);



lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java (line 61)
<https://reviews.apache.org/r/35821/#comment144032>

    this can be changed to use constant expected value instead of making partitionCost package private.
    
    assertEquals(cost2.getEstimatedResourceUsage(), 0.2);



lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java (line 67)
<https://reviews.apache.org/r/35821/#comment144033>

    Shall we have a test for compareTo returning 0 as well ?



lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java (line 73)
<https://reviews.apache.org/r/35821/#comment144034>

    On doing this way add method is getting coupled in equals test. A break in add will break equals test as well. Also the use case when equals returns false is not getting tested .
    
    Lets decouple and simplify this as below.
    
    QueryCost testCost1 = new XYZ(0.5);
    QueryCost testCost2 = new XYZ(0.5);
    QueryCost testCost3 = new XYZ(0.6);
    
    assertTrue(testCost1.equals(testCost2);
    assertFalse(testCost1.equals(testCost3);


- Himanshu Gahlaut


On July 7, 2015, 10:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:37 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90890
-----------------------------------------------------------

Ship it!


Ship It!

- Himanshu Gahlaut


On July 8, 2015, 11:16 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 11:16 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 9, 2015, 11:19 a.m., Amareshwari Sriramadasu wrote:
> > >> With the new design, estimate on native queries does no validation, just returns MAX_COST. 
> > 
> > Why are invalid native queries not failing any more? I see that as a regression in this patch. Also, whats the reason for returning MAX_COST?

I'm taking care of Failure of invalid queries in the next patch. 

About Max cost, the motivation is to encourage olap queries and discourage native queries. Native queries can be run directly from hive shell as well.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review91068
-----------------------------------------------------------


On July 9, 2015, 10:18 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 10:18 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> `QueryAPIErrorResponseTest.testErrorResponseWhenLensMultiCauseExceptionOccurs` is failing. It relies on `estimate` failing for invalid native queries. e.g. `select blah from nonexisting_table`. With the new design, estimate on native queries does no validation, just returns MAX_COST. Since the test case expects estimate to return 500 error response, it's failing. Initially I thought calling explain instead of estimate would throw MultiCause Exception but it doesn't. 
> 
> Currently I need a way to get Multi Cause Exception. 
> 
> All other tests pass.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review91068
-----------------------------------------------------------


>> With the new design, estimate on native queries does no validation, just returns MAX_COST. 

Why are invalid native queries not failing any more? I see that as a regression in this patch. Also, whats the reason for returning MAX_COST?

- Amareshwari Sriramadasu


On July 9, 2015, 4:48 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 4:48 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> `QueryAPIErrorResponseTest.testErrorResponseWhenLensMultiCauseExceptionOccurs` is failing. It relies on `estimate` failing for invalid native queries. e.g. `select blah from nonexisting_table`. With the new design, estimate on native queries does no validation, just returns MAX_COST. Since the test case expects estimate to return 500 error response, it's failing. Initially I thought calling explain instead of estimate would throw MultiCause Exception but it doesn't. 
> 
> Currently I need a way to get Multi Cause Exception. 
> 
> All other tests pass.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 9, 2015, 12:29 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.013s]
[INFO] Lens .............................................. SUCCESS [2.880s]
[INFO] Lens API .......................................... SUCCESS [19.485s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.401s]
[INFO] Lens Cube ......................................... SUCCESS [3:28.333s]
[INFO] Lens DB storage ................................... SUCCESS [18.956s]
[INFO] Lens Query Library ................................ SUCCESS [15.739s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:44.293s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.007s]
[INFO] Lens Server ....................................... SUCCESS [6:39.321s]
[INFO] Lens client ....................................... SUCCESS [36.269s]
[INFO] Lens CLI .......................................... SUCCESS [2:36.761s]
[INFO] Lens Examples ..................................... SUCCESS [9.848s]
[INFO] Lens Distribution ................................. SUCCESS [8.001s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.914s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.936s]
[INFO] Lens Regression ................................... SUCCESS [10.694s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:48.706s
[INFO] Finished at: Thu Jul 09 06:57:50 UTC 2015
[INFO] Final Memory: 171M/1290M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 9, 2015, 10:18 a.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing (updated)
-------

`QueryAPIErrorResponseTest.testErrorResponseWhenLensMultiCauseExceptionOccurs` is failing. It relies on `estimate` failing for invalid native queries. e.g. `select blah from nonexisting_table`. With the new design, estimate on native queries does no validation, just returns MAX_COST. Since the test case expects estimate to return 500 error response, it's failing. Initially I thought calling explain instead of estimate would throw MultiCause Exception but it doesn't. 

Currently I need a way to get Multi Cause Exception. 

All other tests pass.


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 8, 2015, 7:01 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing (updated)
-------

`QueryAPIErrorResponseTest.testErrorResponseWhenInvalidOperationIsSubmitted` is failing. It relies on `estimate` failing for invalid native queries. e.g. `select blah from nonexisting_table`. With the new design, estimate on native queries does no validation, just returns MAX_COST. Since the test case expects estimate to return 500 error response, it's failing. Initially I thought calling explain instead of estimate would throw MultiCause Exception but it doesn't. 

Currently I need a way to get Multi Cause Exception. 

All other tests pass.


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 8, 2015, 4:46 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 2d20789f2f92ea1424fee35c9dc5c3ec39333f3d 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 7, 2015, 4:07 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestFactPartition.java PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 6, 2015, 6:41 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 6, 2015, 6:09 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java, line 32
> > <https://reviews.apache.org/r/35821/diff/7/?file=999749#file999749line32>
> >
> >     Is separate class required here?
> >     
> >     can we have the buildTO() in QueryCost itself?

QueryCost is an interface. Wanted to avoid making it an abstract class.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90474
-----------------------------------------------------------


On July 6, 2015, 5:56 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 5:56 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90474
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java (line 32)
<https://reviews.apache.org/r/35821/#comment143560>

    Is separate class required here?
    
    can we have the buildTO() in QueryCost itself?


- Amareshwari Sriramadasu


On July 6, 2015, 12:26 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 12:26 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 6, 2015, 5:56 p.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTOBuilder.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 6, 2015, 4:23 p.m.)


Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 6, 2015, 4:17 p.m.)


Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
  lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 6, 2015, 4:01 p.m.)


Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
  lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90369
-----------------------------------------------------------


Please add unit test cases for following classes. Please use mocks (if required) to simplify testing.

FactPartitionBasedQueryCostTest

FactPartitionTest: Only adding unit test for new method which calculates sum of storage table weights would be good enough for now.

FactPartitionBasedQueryCostCalculatorTest

CostRangePriorityDeciderTest

- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90364
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java (line 309)
<https://reviews.apache.org/r/35821/#comment143388>

    This will fail for every query and add a log with ERROR. Normally people grep logs for ERROR keyword to identify deployment issues after deployment. This sort of logs become false alarms and confuse new comers. It is acceptable for an implementation, in current context, to throw UnsupportedOperationException. It can be a debug log at max. Also please use parametrized substitution instead of +.


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 3, 2015, 11:03 p.m., Himanshu Gahlaut wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java, line 27
> > <https://reviews.apache.org/r/35821/diff/3/?file=998844#file998844line27>
> >
> >     @Data makes lot of things including public getter/setter method on member variables which violates data hiding.
> >     
> >     Please use @EqualsAndHashCode and @ToString only. I guess this class does not need @Getter as well. The only public methods present in this  implementation should be of the implemented interface. Exceptions are equals, hashcode and toString which are already inherited from Object class.
> 
> Rajat Khandelwal wrote:
>     It needs a getter. In add and compare methods, getter on the internal cost variable is required. 
>     
>     @Data == @ToString + @EqualsAndHashCode + @Getter(only one, which is required) + @Setter(0, since final) + @RequiredArgsConstructor (Not generated, since custom constructor provided)
> 
> Himanshu Gahlaut wrote:
>     where is getter required ?

For add, it needs `other.getPartitionCost()`


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------


On July 6, 2015, 4:01 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 4:01 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/Addable.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostToPriorityRangeConf.java 97574b830cb4924e0eb9624f04dbce10fcaf4fdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 75295ab711d986c3f6a0d33bd241fe0d3873bdd5 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/CostToPriorityRangeConf.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/QueryPriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java PRE-CREATION 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 060a867c03d8509adf646282745ec30a9f3ac6e1 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 17305e2e8f1680278e5d621fa2bc745795953bed 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 3, 2015, 5:33 p.m., Himanshu Gahlaut wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java, line 36
> > <https://reviews.apache.org/r/35821/diff/3/?file=998844#file998844line36>
> >
> >     If @NonNull is not present and a null value is passed, code here will throw a NullPointerException at line 37 without going into any inconsistent state. 
> >     
> >     In such cases, a precondition of @NonNull which throws a NullPointerException can be avoided. The written code will automatically fall into same behaviour without any extra check.

Some reference from JDK: http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/AbstractCollection.java#AbstractCollection.containsAll%28java.util.Collection%29

Pass a null to containsAll method. It will automatically throw a NullPointerException without any precondition check at the start of method.

This doesn't mean that @NonNull is not helpful. @NonNull is helpful in Constructors, where avoids construction of objects with nulls. Precondition @NonNull is also helpful in behaviours when system can be left into inconsistent state due to a NullPointerException which comes from intermediate logic instead of precondition.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 3, 2015, 11:03 p.m., Himanshu Gahlaut wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java, line 27
> > <https://reviews.apache.org/r/35821/diff/3/?file=998844#file998844line27>
> >
> >     @Data makes lot of things including public getter/setter method on member variables which violates data hiding.
> >     
> >     Please use @EqualsAndHashCode and @ToString only. I guess this class does not need @Getter as well. The only public methods present in this  implementation should be of the implemented interface. Exceptions are equals, hashcode and toString which are already inherited from Object class.

It needs a getter. In add and compare methods, getter on the internal cost variable is required. 

@Data == @ToString + @EqualsAndHashCode + @Getter(only one, which is required) + @Setter(0, since final) + @RequiredArgsConstructor (Not generated, since custom constructor provided)


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------


On July 3, 2015, 5:38 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 5:38 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 3, 2015, 5:33 p.m., Himanshu Gahlaut wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java, line 27
> > <https://reviews.apache.org/r/35821/diff/3/?file=998844#file998844line27>
> >
> >     @Data makes lot of things including public getter/setter method on member variables which violates data hiding.
> >     
> >     Please use @EqualsAndHashCode and @ToString only. I guess this class does not need @Getter as well. The only public methods present in this  implementation should be of the implemented interface. Exceptions are equals, hashcode and toString which are already inherited from Object class.
> 
> Rajat Khandelwal wrote:
>     It needs a getter. In add and compare methods, getter on the internal cost variable is required. 
>     
>     @Data == @ToString + @EqualsAndHashCode + @Getter(only one, which is required) + @Setter(0, since final) + @RequiredArgsConstructor (Not generated, since custom constructor provided)

where is getter required ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 3, 2015, 5:33 p.m., Himanshu Gahlaut wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java, line 32
> > <https://reviews.apache.org/r/35821/diff/3/?file=998844#file998844line32>
> >
> >     Shall we have a check that partitionCost cannot be negative ?
> >     
> >     checkArgument(partitionCost >= 0, "Partition cost cannot be positive")

can't edit a comment here. The error msg is incorrect in above comment. It shall be "Partition cost cannot be negative"


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review90353
-----------------------------------------------------------



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 27)
<https://reviews.apache.org/r/35821/#comment143368>

    @Data makes lot of things including public getter/setter method on member variables which violates data hiding.
    
    Please use @EqualsAndHashCode and @ToString only. I guess this class does not need @Getter as well. The only public methods present in this  implementation should be of the implemented interface. Exceptions are equals, hashcode and toString which are already inherited from Object class.



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 29)
<https://reviews.apache.org/r/35821/#comment143369>

    Please make this final



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 31)
<https://reviews.apache.org/r/35821/#comment143370>

    Please add a final to argument.



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 32)
<https://reviews.apache.org/r/35821/#comment143374>

    Shall we have a check that partitionCost cannot be negative ?
    
    checkArgument(partitionCost >= 0, "Partition cost cannot be positive")



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 36)
<https://reviews.apache.org/r/35821/#comment143373>

    If @NonNull is not present and a null value is passed, code here will throw a NullPointerException at line 37 without going into any inconsistent state. 
    
    In such cases, a precondition of @NonNull which throws a NullPointerException can be avoided. The written code will automatically fall into same behaviour without any extra check.



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 56)
<https://reviews.apache.org/r/35821/#comment143371>

    partitionCost gives an estimation of resource usage. In light of this, will it be ok to change return type of getEstimatedResourceUsage to float and return partition cost from getEstimatedResourceUsage. This will allow us to  remove getEstimatedCost from the interface and also remove throws UnsupportedOperationException from estimatedResourceUsage ?



lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java (line 61)
<https://reviews.apache.org/r/35821/#comment143372>

    How about adding a final to argument ?


- Himanshu Gahlaut


On July 3, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
>   lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
>   lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
>   lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
>   lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 3, 2015, 5:38 p.m.)


Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/FactPartitionBasedQueryCost.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java a836b1e433b50e3137aba71ac8c8288ca7a2f5bf 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 2177c7887ff7cae395f9ef1a8dcf1f1489bcf6ca 
  lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 3465513c10a13fb062a6b64e5589862d3d0141dd 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 841946d2cc8ef9f1a590acd1693404fbdf60ac49 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/FactPartitionBasedQueryCostCalculator.java PRE-CREATION 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50 
  lens-examples/src/main/resources/city-local-part.xml 528b8808ab7c9e508e4bf00c158a8b319d957f93 
  lens-examples/src/main/resources/sales-aggr-fact1.xml 728c77548ddcf22002c8927ba57a9fad8e01cf31 
  lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java 8957aefec894485fc3d1e26e3f3b4f79eb01915e 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 51b12177a3b7c6db5beb4b98a892bc83cc94fcdf 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 43237f76a75e5c020534548bb9ec5e423e2b360c 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 3c0f7876d96e2f7dd9a0468ec94a7abcec41f819 
  lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
  lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java ec97b8df25f57a283d4d539d635c011cd06819d6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 655549b25aa2e6aef507c164c0e87d69e856961e 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/
-----------------------------------------------------------

(Updated July 3, 2015, 5:07 p.m.)


Review request for lens.


Bugs: LENS-630
    https://issues.apache.org/jira/browse/LENS-630


Repository: lens


Description
-------

Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.


Diffs (updated)
-----

  checkstyle/pom.xml 013e3913e87052456c7f4630b05a62e192c7845b 
  lens-api/pom.xml 66c038098aaa4a8943c6714ae01f883cf7cd3f71 
  lens-cli/pom.xml d6dba49674af3414490c5598ffd0fb32ae62e349 
  lens-client/pom.xml 6c1ae8fba383cbc233444cee91f0a2d339c6fa29 
  lens-cube/pom.xml ea110afe88db60fc2a4a7adfd724da7e6d9a8812 
  lens-dist/pom.xml ab9c87af6edd1ee1bf672b26af33f00e9fee6e72 
  lens-dist/src/deb/control/postinst PRE-CREATION 
  lens-docker/lens-test/Dockerfile 46252f184e437e1ffd351bf1453ebdb11cc7866d 
  lens-docker/lens-test/lens-bootstrap.sh bdc5e2cb7929b750df5d517a1c18c060e417de9a 
  lens-driver-hive/pom.xml e3d3aade38ad155bf4fd1f360525c0b077c52e90 
  lens-driver-jdbc/pom.xml 0515941b4ec6f626a68b08bd47fd117ee6f85b34 
  lens-examples/pom.xml 1406e98ebc2baee666489ec573157b9db8146e50 
  lens-ml-dist/pom.xml 0ed11301d67329ff172cd27b62492c84b0f7df8e 
  lens-ml-lib/pom.xml f8f2b8537753bb7903207e0ac6f3448916420c1c 
  lens-query-lib/pom.xml 454df63f57ce8942159545f79199741e894c5891 
  lens-regression/pom.xml dd97637a0d515ea551263c7db7a0a353603adb34 
  lens-server-api/pom.xml 26ac76373f3c5c56d144d7f9baec43819c6efce7 
  lens-server/pom.xml f9a16cbb3e73993bd8a7c4ced97281847b6eb247 
  lens-storage-db/pom.xml f8752224af2233317f4172669668b89cf2273315 
  pom.xml ee540513c5353cf586b15208af01bcd36d4fd9e4 
  tools/conf-pseudo-distr/server/hivedriver-site.xml 67daeeba33d7008c2848b4e15bd1da31f2be2832 
  tools/scripts/generate-site-public.sh 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256 

Diff: https://reviews.apache.org/r/35821/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.277s]
[INFO] Lens API .......................................... SUCCESS [20.678s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
[INFO] Lens DB storage ................................... SUCCESS [19.018s]
[INFO] Lens Query Library ................................ SUCCESS [15.157s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
[INFO] Lens Server ....................................... SUCCESS [5:45.727s]
[INFO] Lens client ....................................... SUCCESS [38.252s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
[INFO] Lens Examples ..................................... SUCCESS [9.162s]
[INFO] Lens Distribution ................................. SUCCESS [8.978s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
[INFO] Lens Regression ................................... SUCCESS [10.724s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.407s
[INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89323
-----------------------------------------------------------



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 34)
<https://reviews.apache.org/r/35821/#comment141907>

    Could this java comment be moved near to the field to which it belongs ?  I'm assuming that this comment is for updatePeriodWeights, if yes, could we choose one between updatePeriodWeights and Parition Weights and use it consistently in field name and in javadoc comment.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 101)
<https://reviews.apache.org/r/35821/#comment141908>

    This check could be moved as a Preconditions.checkState on updatePeriodWeights in DurationBasedQueryCostCalculator constructor. Advantage is that, DurationBasedQueryCostCalculator will be created in valid state for all behaviours, and a new behaviour added in future will not have to repeat this check.


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On June 24, 2015, 11:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java, line 68
> > <https://reviews.apache.org/r/35821/diff/1/?file=991170#file991170line68>
> >
> >     I feel this value is only internal and should not be returned to user through QueryCost

It might help clients in doing relative comparison of cube queries via result of estimate REST API. E.g. A User Interface might be interested in showing queries which have cost between 0 and N in green color where as queris which have cost > N in red color. Another user interface might choose to use three colors instead of two and show queries with cost between 0 to M in green, M to N in yellow, and > N in red.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89149
-----------------------------------------------------------


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On June 24, 2015, 11:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java, line 68
> > <https://reviews.apache.org/r/35821/diff/1/?file=991170#file991170line68>
> >
> >     I feel this value is only internal and should not be returned to user through QueryCost
> 
> Himanshu Gahlaut wrote:
>     It might help clients in doing relative comparison of cube queries via result of estimate REST API. E.g. A User Interface might be interested in showing queries which have cost between 0 and N in green color where as queris which have cost > N in red color. Another user interface might choose to use three colors instead of two and show queries with cost between 0 to M in green, M to N in yellow, and > N in red.

Altrenative thought could be to abstract out clients and build a translation in lens presentation layer which can translate float cost returned by QueryCost interface into EstimateResult. EstimateResult could be composed of QueryCostType. QueryCostType could be an enum which can have three values LOW_COST, MEDIUM_COST, HIGH_COST. A translation within lens presentation layer would be more aligned with the thought mentioned by Amareshwari for keeping cost internal.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89149
-----------------------------------------------------------


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On June 24, 2015, 11:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java, line 68
> > <https://reviews.apache.org/r/35821/diff/1/?file=991170#file991170line68>
> >
> >     I feel this value is only internal and should not be returned to user through QueryCost
> 
> Himanshu Gahlaut wrote:
>     It might help clients in doing relative comparison of cube queries via result of estimate REST API. E.g. A User Interface might be interested in showing queries which have cost between 0 and N in green color where as queris which have cost > N in red color. Another user interface might choose to use three colors instead of two and show queries with cost between 0 to M in green, M to N in yellow, and > N in red.
> 
> Himanshu Gahlaut wrote:
>     Altrenative thought could be to abstract out clients and build a translation in lens presentation layer which can translate float cost returned by QueryCost interface into EstimateResult. EstimateResult could be composed of QueryCostType. QueryCostType could be an enum which can have three values LOW_COST, MEDIUM_COST, HIGH_COST. A translation within lens presentation layer would be more aligned with the thought mentioned by Amareshwari for keeping cost internal.

Addition of a method QueryCostType getQueryCostType(); to QueryCost interface is another alternative.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89149
-----------------------------------------------------------


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89149
-----------------------------------------------------------



lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java (line 68)
<https://reviews.apache.org/r/35821/#comment141751>

    I feel this value is only internal and should not be returned to user through QueryCost


- Amareshwari Sriramadasu


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On June 25, 2015, 12:31 p.m., Himanshu Gahlaut wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java, line 68
> > <https://reviews.apache.org/r/35821/diff/1/?file=991174#file991174line68>
> >
> >     An instanceof check is normally a code smell. Could this be handled by polymorphism ? And if this can't be handled with polymorphism. Lets call  out the reason for the same.

Called out.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89325
-----------------------------------------------------------


On July 3, 2015, 5:07 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 5:07 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   checkstyle/pom.xml 013e3913e87052456c7f4630b05a62e192c7845b 
>   lens-api/pom.xml 66c038098aaa4a8943c6714ae01f883cf7cd3f71 
>   lens-cli/pom.xml d6dba49674af3414490c5598ffd0fb32ae62e349 
>   lens-client/pom.xml 6c1ae8fba383cbc233444cee91f0a2d339c6fa29 
>   lens-cube/pom.xml ea110afe88db60fc2a4a7adfd724da7e6d9a8812 
>   lens-dist/pom.xml ab9c87af6edd1ee1bf672b26af33f00e9fee6e72 
>   lens-dist/src/deb/control/postinst PRE-CREATION 
>   lens-docker/lens-test/Dockerfile 46252f184e437e1ffd351bf1453ebdb11cc7866d 
>   lens-docker/lens-test/lens-bootstrap.sh bdc5e2cb7929b750df5d517a1c18c060e417de9a 
>   lens-driver-hive/pom.xml e3d3aade38ad155bf4fd1f360525c0b077c52e90 
>   lens-driver-jdbc/pom.xml 0515941b4ec6f626a68b08bd47fd117ee6f85b34 
>   lens-examples/pom.xml 1406e98ebc2baee666489ec573157b9db8146e50 
>   lens-ml-dist/pom.xml 0ed11301d67329ff172cd27b62492c84b0f7df8e 
>   lens-ml-lib/pom.xml f8f2b8537753bb7903207e0ac6f3448916420c1c 
>   lens-query-lib/pom.xml 454df63f57ce8942159545f79199741e894c5891 
>   lens-regression/pom.xml dd97637a0d515ea551263c7db7a0a353603adb34 
>   lens-server-api/pom.xml 26ac76373f3c5c56d144d7f9baec43819c6efce7 
>   lens-server/pom.xml f9a16cbb3e73993bd8a7c4ced97281847b6eb247 
>   lens-storage-db/pom.xml f8752224af2233317f4172669668b89cf2273315 
>   pom.xml ee540513c5353cf586b15208af01bcd36d4fd9e4 
>   tools/conf-pseudo-distr/server/hivedriver-site.xml 67daeeba33d7008c2848b4e15bd1da31f2be2832 
>   tools/scripts/generate-site-public.sh 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89325
-----------------------------------------------------------



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 32)
<https://reviews.apache.org/r/35821/#comment141913>

    The implementation is more focused on selected Fact Partitions. Would FactPartitionBasedQueryCostCalculator be a more intent revealing name ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 63)
<https://reviews.apache.org/r/35821/#comment141912>

    There is no directly visible check here which enforces that this calculation is happening for only cube queries. Could this comment be rephrased to focus on logic being implemented from line 66 to line 72 ?
    
    Also wouldn't it be better to penalise the unknown bucket queries and assign them highest weight, instead of assigning them lowest weight ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 67)
<https://reviews.apache.org/r/35821/#comment141914>

    queryContext.getDriverContext().getDriverRewriterPlan(driver).getPartitions().entrySet()
    
    This chain of getters is hard to read. Could we give it a name by creating a private method and make code more readable ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 68)
<https://reviews.apache.org/r/35821/#comment141916>

    An instanceof check is normally a code smell. Could this be handled by polymorphism ? And if this can't be handled with polymorphism. Lets call  out the reason for the same.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java (line 80)
<https://reviews.apache.org/r/35821/#comment141915>

    Could this method be implemented as, float getAllTableWeights(final AbstractQueryContext queryContext), in FactPartion class ? This will make it more reusable.


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89341
-----------------------------------------------------------


Unit test cases for following classes have to be implemented:


DurationBasedQueryCostCalculator
CostRangePriorityDecider
implementation of QueryCost

- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89340
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java (line 37)
<https://reviews.apache.org/r/35821/#comment141926>

    This constructor shall accept CostToPriorityRangeConf directly instead of ranges. This will decouple CostRangePriorityDecider from String ranges.
    
    ```
    public CostRangePriorityDecider(@NonNull CostToPriorityRangeConf conf) 
    ```



lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java (line 43)
<https://reviews.apache.org/r/35821/#comment141927>

    Parametrized substitution can be used here for logging.
    
    log.info("cost was: {}, decided priority: {}
    ", cost, p);


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 35821: LENS-630: Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35821/#review89327
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java (line 31)
<https://reviews.apache.org/r/35821/#comment141917>

    Could we remove Normalized keyword from interface definition and method name, or we shall define the normalization scale to be used by multiple implementations of interface ?
    
    Also implementations may choose to not use "the explained plans for each driver" in calculating query cost. This is an implementation detail which may not be eligible to be a part of interface definition.


- Himanshu Gahlaut


On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35821/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:37 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-630
>     https://issues.apache.org/jira/browse/LENS-630
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Along with this, we can add a new field in QueryCost to return the query cost calculated by the implementation. normalizedQueryCost could be one name for that field.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java 1a37c20f408dac8d007e917a3b1107c96acb51f1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 3c9268bc7f23687bd450cf01a44272df50a2df26 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b0a04dfc59e2301aac336a97fe52024c4ebf76df 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java PRE-CREATION 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java bc1ec1c619f980d7a18314cb93d5438fc1d11321 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java 09a8ace5e4738b338ec241c83e297d071949a4bf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c398215f415c20b2bfcd3d743316f7300ac2baa1 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 09452226337bbacb12216efd43f15a2b957c0cf4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 
> 
> Diff: https://reviews.apache.org/r/35821/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.277s]
> [INFO] Lens API .......................................... SUCCESS [20.678s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.428s]
> [INFO] Lens Cube ......................................... SUCCESS [3:37.068s]
> [INFO] Lens DB storage ................................... SUCCESS [19.018s]
> [INFO] Lens Query Library ................................ SUCCESS [15.157s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s]
> [INFO] Lens Server ....................................... SUCCESS [5:45.727s]
> [INFO] Lens client ....................................... SUCCESS [38.252s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.316s]
> [INFO] Lens Examples ..................................... SUCCESS [9.162s]
> [INFO] Lens Distribution ................................. SUCCESS [8.978s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s]
> [INFO] Lens Regression ................................... SUCCESS [10.724s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.407s
> [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>