You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/07/24 15:45:56 UTC

[orc] branch branch-1.7 updated: ORC-861: Bump CMake minimum requirement to 2.8.12 (#763)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/branch-1.7 by this push:
     new 1d8f14e  ORC-861: Bump CMake minimum requirement to 2.8.12 (#763)
1d8f14e is described below

commit 1d8f14e08c9ed26dfc332787ec8549a2aa421dba
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Sat Jul 24 08:45:08 2021 -0700

    ORC-861: Bump CMake minimum requirement to 2.8.12 (#763)
    
    ### What changes were proposed in this pull request?
    
    This PR aims to bump CMake minimum requirement from 2.6 to 2.8.12.
    
    ### Why are the changes needed?
    
    As of today, we are currently using CMake 3.21.0 and hitting this warning because our minimum requirement is 2.6.
    ```
    $ cmake --version
    cmake version 3.21.0
    
    $ cmake ..
    CMake Deprecation Warning at CMakeLists.txt:13 (cmake_minimum_required):
      Compatibility with CMake < 2.8.12 will be removed from a future version of
      CMake.
    
      Update the VERSION argument <min> value or use a ...<max> suffix to tell
      CMake that the project does not need compatibility with older versions.
    ```
    
    ### How was this patch tested?
    
    Pass the CIs
    
    (cherry picked from commit 837f26485b69774ad2f580c5feb5e612a4fd6251)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9b7e780..fa5be37 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,7 +10,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-cmake_minimum_required (VERSION 2.6)
+cmake_minimum_required (VERSION 2.8.12)
 if (POLICY CMP0048)
     cmake_policy(SET CMP0048 NEW)
 endif ()