[jira] [Commented] (HDFS-14195) OIV: print out storage policy id in oiv Delimited output

["Adam Antal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833791#comment-16833791 ] 

Adam Antal commented on HDFS-14195:
-----------------------------------

Hi,

Thanks for the patch [~suxingfate]. Yes, thanks for the items having been addressed. 

Some cosmetics there:
 * {{java.io.*}} wildcard import is still there. It's matter of taste, but I prefer explicitly stating the used imports.
 * Also could you remove the extra line there:
{code:java}
try (
	            ByteArrayInputStream input =
	                    new ByteArrayInputStream(output.toByteArray());
{code}

I'm +1 (non-binding) on committing this, thanks again for the work. [~jojochuang], could you please take a look and commit this, if you agree. Also [~smeng], if you have time for the review I'd be glad, since you have great knowledge around the OIV tool.

> OIV: print out storage policy id in oiv Delimited output
> --------------------------------------------------------
>
>                 Key: HDFS-14195
>                 URL: https://issues.apache.org/jira/browse/HDFS-14195
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Wang, Xinglong
>            Priority: Minor
>         Attachments: HDFS-14195.001.patch, HDFS-14195.002.patch, HDFS-14195.003.patch, HDFS-14195.004.patch, HDFS-14195.005.patch
>
>
> There is lacking of a method to get all folders and files with sort of specified storage policy via command line, like ALL_SSD type.
> By adding storage policy id to oiv output, it will help with oiv post-analysis to have a overview of all folders/files with specified storage policy and to apply internal regulation based on this information.
>  
> Currently, for PBImageXmlWriter.java, in HDFS-9835 it added function to print out xattr which including storage policy already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org