You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/08/25 09:54:47 UTC
[GitHub] activemq-artemis pull request #734: Misc small improvements
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/734
Misc small improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 62cb97bf30f6809ee89bb9ab924dcae3edf7fea3
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-08-25T09:07:24Z
Unnecessary @SuppressWarnings fixes
commit a94406636062c8e32d03dd14ffc5ef59e3e83300
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-08-25T09:08:08Z
Unchecked warning suppression fixes
commit d1d96e6d0445d7a04310215356403d21438369ff
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-08-25T09:08:39Z
Missing @Override fixes
commit 158fe89cc7d0d52654f769e7c5834f13bd18a334
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-08-25T09:31:57Z
Potential resource leak fixes
commit f5fe92b3e74bfba3d6231496bcdda23b0dd152b5
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-08-25T09:53:30Z
Spelling fixes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #734: Misc small improvements
Posted by scop <gi...@git.apache.org>.
Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/734#discussion_r76302651
--- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java ---
@@ -154,18 +154,22 @@ public Object run() {
}
}
+ @Override
--- End diff --
Me too :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #734: Misc small improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #734: Misc small improvements
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/734#discussion_r76297886
--- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java ---
@@ -154,18 +154,22 @@ public Object run() {
}
}
+ @Override
--- End diff --
I wish there was a checkstyle to catch those
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---