You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by javadba <gi...@git.apache.org> on 2014/07/28 07:00:43 UTC
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
GitHub user javadba opened a pull request:
https://github.com/apache/spark/pull/1615
SPARK-2712 - Add a small note to maven doc that mvn package must happen ...
Per request by Reynold adding small note about proper sequencing of build then test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/javadba/spark docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1615
----
commit 57647574caf2956416f2e92cee7376941f239248
Author: Stephen Boesch <ja...@gmail.com>
Date: 2014-07-28T03:50:11Z
SPARK-2712 - Add a small note to maven doc that mvn package must happen before test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1615#issuecomment-50300494
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by javadba <gi...@git.apache.org>.
Github user javadba commented on the pull request:
https://github.com/apache/spark/pull/1615#issuecomment-50994967
Apologies for the long delay - it was induced by a moderately arduous process of learning git workflows/rebase-ing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1615#issuecomment-50720702
@rxin @javadba - I believe this is covered already in the maven docs:
http://spark.apache.org/docs/latest/building-with-maven.html#spark-tests-in-maven
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1615#issuecomment-50720880
maybe it would make sense to just enhance the existing section and clearly show that you need to run "mvn package" and then "mvn test" with a similar code block to the one in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1615#issuecomment-50996658
Okay great - went ahead and merged this with a small typo fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org