You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/06 14:07:18 UTC

[GitHub] [superset] codyml commented on a diff in pull request #20612: chore(explore): update Explore icons and icon colors

codyml commented on code in PR #20612:
URL: https://github.com/apache/superset/pull/20612#discussion_r914884881


##########
superset-frontend/src/explore/components/ControlHeader.tsx:
##########
@@ -78,12 +82,13 @@ const ControlHeader: FC<ControlHeaderProps> = ({
       >
         {description && (
           <span>
-            <InfoTooltipWithTrigger

Review Comment:
   It's still used on line 96 to render the lightning bolt icon, do you think I should replace that with a plain `<Tooltip>...</Tooltip>` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org