[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #291: Switch to file output stream for large data

[GitBox <gi...@apache.org>]

jadams-tresys commented on a change in pull request #291: Switch to file output stream for large data
URL: https://github.com/apache/incubator-daffodil/pull/291#discussion_r352748481
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DirectOrBufferedDataOutputStream.scala
 ##########
 @@ -822,7 +843,7 @@ class DirectOrBufferedDataOutputStream private[io] (
           bufOS.flush
           val nBitsPut = directDOS.putFile(
             bufOS.tempFile.toPath,
-            bufOS.nBytes * 8, chunkSizeInBytes, finfo)
+            bufferNBits.toLong, chunkSizeInBytes, finfo)
           nBitsPut / 8
         } else
           directDOS.putBytes(bufOS.getBuf, 0, nBytes, finfo)
 
 Review comment:
   My last commit had this mistake, but the original Blob code did not.  I'm making this a little more explicit by having an existingFileLengthInBits value that gets passed in, which would be used for the blob length.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services